New issue
Advanced search Search tips

Issue 906357 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Nov 27
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug



Sign in to add a comment

CHECK failure: !result.opaque() in security_origin.cc

Project Member Reported by ClusterFuzz, Nov 17

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6475906498166784

Fuzzer: libFuzzer_feature_policy_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !result.opaque() in security_origin.cc
  blink::SecurityOrigin::ToUrlOrigin
  blink::ParseFeaturePolicy
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=598890:598907

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6475906498166784

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Nov 17

Labels: OS-Windows
Project Member

Comment 2 by ClusterFuzz, Nov 17

Components: Blink>Internals
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Nov 17

Cc: iclell...@chromium.org
Labels: ClusterFuzz-Auto-CC
Automatically adding ccs based on OWNERS file / target commit history.

If this is incorrect, please add ClusterFuzz-Wrong label.
Project Member

Comment 4 by ClusterFuzz, Nov 17

Labels: Test-Predator-Auto-Owner
Owner: iclell...@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/32487da8d09caf3eb72b9c70f60887e2237f4751 (Move Feature Policy parser from platform to core).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
Looks like SecurityOrigin treats multiply-wrapped URLs (like blob:filesystem:xxxxxxx) as valid, and non-opaque, while url::Origin rejects them as invalid tuple origins. The mismatch triggers a DCHECK in SecurityOrigin::ToUrlOrigin.
Cc: dcheng@chromium.org
Project Member

Comment 8 by bugdroid1@chromium.org, Nov 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2984d826c17a8bc7d01c1344aea831a674ee1e75

commit 2984d826c17a8bc7d01c1344aea831a674ee1e75
Author: Ian Clelland <iclelland@chromium.org>
Date: Mon Nov 26 22:15:41 2018

Treat multiply-wrapped URLs as opaque

Bug:  906357 
Change-Id: I1fab7e52c71a7358a5f22e2fc99cda064b29918d
Reviewed-on: https://chromium-review.googlesource.com/c/1348257
Reviewed-by: Mike West <mkwst@chromium.org>
Commit-Queue: Ian Clelland <iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610960}
[modify] https://crrev.com/2984d826c17a8bc7d01c1344aea831a674ee1e75/third_party/blink/renderer/platform/weborigin/security_origin.cc
[modify] https://crrev.com/2984d826c17a8bc7d01c1344aea831a674ee1e75/third_party/blink/renderer/platform/weborigin/security_origin_test.cc

Project Member

Comment 9 by ClusterFuzz, Nov 27

ClusterFuzz has detected this issue as fixed in range 610959:610960.

Detailed report: https://clusterfuzz.com/testcase?key=6475906498166784

Fuzzer: libFuzzer_feature_policy_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: CHECK failure
Crash Address: 
Crash State:
  !result.opaque() in security_origin.cc
  blink::SecurityOrigin::ToUrlOrigin
  blink::ParseFeaturePolicy
  
Sanitizer: undefined (UBSAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=598890:598907
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=610959:610960

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6475906498166784

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Nov 27

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 6475906498166784 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment