Flaky test: LoginScreenDefaultPolicyLoginScreenBrowsertest.DeviceLoginScreenDefaultVirtualKeyboardEnabled Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.chromiumos/linux-chromeos-dbg/8949 Test output log: https://chromium-swarm.appspot.com/task?id=4139cc55a95e7910 Culprit (70.0% confidence): r608994 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy8QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK6AWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzg5NDkvdml6X2Jyb3dzZXJfdGVzdHMvVEc5bmFXNVRZM0psWlc1RVpXWmhkV3gwVUc5c2FXTjVURzluYVc1VFkzSmxaVzVDY205M2MyVnlkR1Z6ZEM1RVpYWnBZMlZNYjJkcGJsTmpjbVZsYmtSbFptRjFiSFJXYVhKMGRXRnNTMlY1WW05aGNtUkZibUZpYkdWawwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Please revert the culprit, or disable the test and find the appropriate owner. If the culprit above is wrong, please file a bug using this link: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20LoginScreenDefaultPolicyLoginScreenBrowsertest.DeviceLoginScreenDefaultVirtualKeyboardEnabled&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy8QELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCK6AWNocm9taXVtLmNocm9taXVtb3MvbGludXgtY2hyb21lb3MtZGJnLzg5NDkvdml6X2Jyb3dzZXJfdGVzdHMvVEc5bmFXNVRZM0psWlc1RVpXWmhkV3gwVUc5c2FXTjVURzluYVc1VFkzSmxaVzVDY205M2MyVnlkR1Z6ZEM1RVpYWnBZMlZNYjJkcGJsTmpjbVZsYmtSbFptRjFiSFJXYVhKMGRXRnNTMlY1WW05aGNtUkZibUZpYkdWawwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The culprit sounds likely. The builds hit the assertion added in that commit. I'm reverting the CL. [948:948:1117/012353.556575:FATAL:frame_resource_coordinator.cc(73)] Check failed: service_. #0 0x7f3e33f659ed base::debug::StackTrace::StackTrace() #1 0x7f3e33c5fe3a base::debug::StackTrace::StackTrace() #2 0x7f3e33ccbfbe logging::LogMessage::~LogMessage() #3 0x7f3e2022b544 resource_coordinator::FrameResourceCoordinator::SetProcessByID() #4 0x7f3e2023132f _ZN4base8internal13FunctorTraitsIMN20resource_coordinator24FrameResourceCoordinatorEFvRKNS2_18CoordinationUnitIDEEvE6InvokeIS8_NS_7WeakPtrIS3_EEJS6_EEEvT_OT0_DpOT1_ #5 0x7f3e20231235 _ZN4base8internal12InvokeHelperILb1EvE8MakeItSoIMN20resource_coordinator24FrameResourceCoordinatorEFvRKNS4_18CoordinationUnitIDEENS_7WeakPtrIS5_EEJS8_EEEvOT_OT0_DpOT1_ #6 0x7f3e202311b0 _ZN4base8internal7InvokerINS0_9BindStateIMN20resource_coordinator24FrameResourceCoordinatorEFvRKNS3_18CoordinationUnitIDEEJNS_7WeakPtrIS4_EEEEEFvS7_EE7RunImplIS9_NSt3__15tupleIJSB_EEEJLm0EEEEvOT_OT0_NSG_16integer_sequenceImJXspT1_EEEES7_ #7 0x7f3e202310b9 _ZN4base8internal7InvokerINS0_9BindStateIMN20resource_coordinator24FrameResourceCoordinatorEFvRKNS3_18CoordinationUnitIDEEJNS_7WeakPtrIS4_EEEEEFvS7_EE7RunOnceEPNS0_13BindStateBaseES7_ #8 0x7f3e210d8dee _ZNO4base12OnceCallbackIFvRKN20resource_coordinator18CoordinationUnitIDEEE3RunES4_ #9 0x7f3e210d2acc resource_coordinator::mojom::ProcessCoordinationUnit_GetID_ForwardToCallback::Accept() <snip>
Issue 906477 has been merged into this issue.
Revert in progress https://chromium-review.googlesource.com/c/chromium/src/+/1341294
Issue 906326 has been merged into this issue.
Issue 906273 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78c35f24cb3094a2f7758f516a36644f6d1d6c3b commit 78c35f24cb3094a2f7758f516a36644f6d1d6c3b Author: Yuta Kitamura <yutak@chromium.org> Date: Mon Nov 19 07:13:40 2018 Revert "RC: Set Frame->Process association at RenderFrameHost creation." This reverts commit 15fef9cc61f9ad53d8755651f0d40937c3f5d05e. Reason for revert: Likely introduced flaky assertion failure ( bug 906353 ). Original change's description: > RC: Set Frame->Process association at RenderFrameHost creation. > > At present this is only done at navigation time, which can leave frames > disconnected from their hosting process. > > Bug: 901828 > Change-Id: I611eafebe5e7e54c046def38bbaf5b348dedfcb9 > Reviewed-on: https://chromium-review.googlesource.com/c/1318405 > Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: François Doray <fdoray@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Cr-Commit-Position: refs/heads/master@{#608994} TBR=fdoray@chromium.org,wfh@chromium.org,jochen@chromium.org,siggi@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 901828 , 906353 Change-Id: Idd7f4f1caf9a6ab884fd6de17ebb84b09e2c201e Reviewed-on: https://chromium-review.googlesource.com/c/1341294 Reviewed-by: Yuta Kitamura <yutak@chromium.org> Commit-Queue: Yuta Kitamura <yutak@chromium.org> Cr-Commit-Position: refs/heads/master@{#609195} [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/chrome/browser/resource_coordinator/tab_helper.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/content/browser/frame_host/render_frame_host_impl.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/content/browser/frame_host/render_frame_host_impl.h [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/content/browser/renderer_host/render_process_host_impl.h [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/content/public/test/mock_render_process_host.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/coordination_unit/coordination_unit_base.h [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/coordination_unit/process_coordination_unit_impl_unittest.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/observers/metrics_collector_unittest.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/public/cpp/frame_resource_coordinator.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/public/cpp/frame_resource_coordinator.h [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/public/cpp/page_resource_coordinator.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/public/cpp/process_resource_coordinator.cc [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/public/cpp/process_resource_coordinator.h [modify] https://crrev.com/78c35f24cb3094a2f7758f516a36644f6d1d6c3b/services/resource_coordinator/public/mojom/coordination_unit.mojom
This should have fixed flakiness on various tests. Authors, please also see the duplicated bugs as they contain different stacks.
Issue 906549 has been merged into this issue.
Issue 906451 has been merged into this issue.
There have been no crashes on 72.0.3616.0 Win,Mac,Android canary for the duped Issue 906451.
Comment 1 by yutak@chromium.org
, Nov 19Components: Internals>ResourceCoordinator
Owner: yutak@chromium.org
Status: Started (was: Untriaged)