New issue
Advanced search Search tips

Issue 906320 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Flaky-Test: virtual/site-isolated-code-cache/http/tests/devtools/isolated-code-cache/same-origin-test.js



Sign in to add a comment

virtual/site-isolated-code-cache/http/tests/devtools/isolated-code-cache/same-origin-test.js is flaky

Project Member Reported by Findit, Nov 17

Issue description


Flaky test: virtual/site-isolated-code-cache/http/tests/devtools/isolated-code-cache/same-origin-test.js
Sample failed build due to flakiness: https://ci.chromium.org/buildbot/chromium.mac/Mac10.13%20Tests%20%28dbg%29/6530
Test output log: https://chromium-swarm.appspot.com/task?id=413873f6075a4510
Culprit (100.0% confidence): r608486
Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVygwILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLMAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS82NTMwL3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvZG1seWRIVmhiQzl6YVhSbExXbHpiMnhoZEdWa0xXTnZaR1V0WTJGamFHVXZhSFIwY0M5MFpYTjBjeTlrWlhaMGIyOXNjeTlwYzI5c1lYUmxaQzFqYjJSbExXTmhZMmhsTDNOaGJXVXRiM0pwWjJsdUxYUmxjM1F1YW5NPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Please revert the culprit, or disable the test and find the appropriate owner.

If the culprit above is wrong, please file a bug using this link:
https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20virtual/site-isolated-code-cache/http/tests/devtools/isolated-code-cache/same-origin-test.js&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVygwILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLMAWNocm9taXVtLm1hYy9NYWMxMC4xMyBUZXN0cyAoZGJnKS82NTMwL3dlYmtpdF9sYXlvdXRfdGVzdHMgb24gKG5vbmUpIEdQVSBvbiBNYWMvZG1seWRIVmhiQzl6YVhSbExXbHpiMnhoZEdWa0xXTnZaR1V0WTJGamFHVXZhSFIwY0M5MFpYTjBjeTlrWlhaMGIyOXNjeTlwYzI5c1lYUmxaQzFqYjJSbExXTmhZMmhsTDNOaGJXVXRiM0pwWjJsdUxYUmxjM1F1YW5NPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
 
Cc: alph@chromium.org rmcilroy@chromium.org
Labels: -Pri-1 Pri-2
Owner: mythria@chromium.org
This test is a new test added in r608486.

I'm not reverting this, since this test mostly passes within the retries in
the single run of layout tests. I'm assigning mythria@ as the author of this
test.

The failure diff looks like the following:

--- /b/s/w/ioCkh2GG/layout-test-results/virtual/site-isolated-code-cache/http/tests/devtools/isolated-code-cache/same-origin-test-expected.txt
+++ /b/s/w/ioCkh2GG/layout-test-results/virtual/site-isolated-code-cache/http/tests/devtools/isolated-code-cache/same-origin-test-actual.txt
@@ -84,7 +84,7 @@
         columnNumber : 0
         consumedCacheSize : <number>
         lineNumber : 0
-        notStreamedReason : "already used streamed data"
+        notStreamedReason : "script too small"
         streamed : <boolean>
         url : .../devtools/resources/v8-cache-script.js
     }

Thanks for this bug. I think this is happening because the ScriptResource that as fetched earlier could be in the memory cache. If it is in the memory cache we have "already used streamed data" or if it was evicted then we get "script too small". I am trying to force a GC so we get "script too small" always. I will upload a cl for that.

Is there a way I can check if it is still flaky or not? I mean run a try job or something, since I can't reproduce this locally. When I look at the bot it is mostly green, but may be because with num_tries = 3, one of them passes.  
Labels: -Sheriff-Chromium
Chromium Sheriff here.
It looks an owner is assigned. Let me remove Sheriff-Chromium label.

This test failed twice recently:
 - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6725
 - https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/6721

I think reverting the CL would have been a good idea given that it was only adding tests. Now, there are merge conflicts. I'm going to update expectations instead.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 23

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/974e36d8fd6358b0ad646afa6fce1c5630dfbcfd

commit 974e36d8fd6358b0ad646afa6fce1c5630dfbcfd
Author: Mounir Lamouri <mlamouri@chromium.org>
Date: Fri Nov 23 20:13:18 2018

Sheriff: flag flaky devtools code search tests.

Bug: 906320
Change-Id: Ib746b529aa0be13d913a4ee08528e1f8b0d822d4
TBR: mythria@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/1349791
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610663}
[modify] https://crrev.com/974e36d8fd6358b0ad646afa6fce1c5630dfbcfd/third_party/WebKit/LayoutTests/TestExpectations

Sign in to add a comment