New issue
Advanced search Search tips

Issue 906304 link

Starred by 2 users
Status: Fixed
Owner:
thestig@chromium.org
Closed: Nov 17
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

can no longer build with enable_pdf = false

Project Member Reported by dgro...@chromium.org, Nov 17 
$ cat out/Debug/args.gn
# Build arguments go here.
# See "gn args <out_dir> --list" for available build arguments.
enable_nacl = false
enable_pdf = false
enable_print_preview = false
# <api key and client secrets>
is_component_build = true
use_goma = true
is_debug = true

results in

Generating files...
ERROR Unresolved dependencies.
//chrome/browser:browser(//build/toolchain/linux:clang_x64)
  needs //pdf:features(//build/toolchain/linux:clang_x64)

Comment 1 by thestig@chromium.org, Nov 17

Components: -Build
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Probably my fault.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc8ec946cf8aad22bb135d46f349bf262e322716

commit fc8ec946cf8aad22bb135d46f349bf262e322716
Author: Lei Zhang <thestig@chromium.org>
Date: Sat Nov 17 02:53:36 2018

Fix building with enable_pdf = false.

BUG= 906304 

Change-Id: If47e9af167312aa436a022ae1825621a0df286dc
Reviewed-on: https://chromium-review.googlesource.com/c/1340603
Reviewed-by: David Grogan <dgrogan@chromium.org>
Commit-Queue: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609083}
[modify] https://crrev.com/fc8ec946cf8aad22bb135d46f349bf262e322716/chrome/browser/BUILD.gn
[modify] https://crrev.com/fc8ec946cf8aad22bb135d46f349bf262e322716/chrome/browser/about_flags.cc

Comment 3 by thestig@chromium.org, Nov 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment