New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 906295 link

Starred by 2 users
Status: Fixed
Owner:
█ dburger@chromium.org
Last visit 20 days ago
Closed: Nov 27
Cc:
zamorzaev@chromium.org
dgarrett@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

chromeos-infra-unittests-pre-cq broken

Project Member Reported by zamorzaev@chromium.org, Nov 17 
chromeos-infra-unittests-pre-cq broken since Thursday evening due to TestVenvPackages failing.

The first failed build:
https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8929740698611393616

Failure message:
=================================== FAILURES ===================================
__________________ CidbBuildImporterTestCase.testImportRange ___________________

self = <ci_results_archiver.importers.cidb_build_importer_unittest.CidbBuildImporterTestCase testMethod=testImportRange>

    def testImportRange(self):
      """ImportEntries() handles next_id and max_entries."""
>     self._cidb.InsertBuild(**_CreateCidbBuildEntry())
E     TypeError: InsertBuild() got an unexpected keyword argument 'waterfall'

ci_results_archiver/importers/cidb_build_importer_unittest.py:81: TypeError
_____________________ CidbBuildImporterTestCase.testNormal _____________________

self = <ci_results_archiver.importers.cidb_build_importer_unittest.CidbBuildImporterTestCase testMethod=testNormal>

    def testNormal(self):
      """ImportEntries() works in a usual case."""
>     self._cidb.InsertBuild(**_CreateCidbBuildEntry())
E     TypeError: InsertBuild() got an unexpected keyword argument 'waterfall'

ci_results_archiver/importers/cidb_build_importer_unittest.py:37: TypeError
===================== 2 failed, 46 passed in 9.36 seconds ======================
18:07:59: ERROR: 
return code: 1; command: ./bin/run_tests
cmd=['./bin/run_tests'], cwd=/b/swarming/w/ir/cache/cbuild/repository/infra/ci_results_archiver
I suspect the culprit is https://crrev.com/c/1336004, specifically the change to lib/cidb.py (or fake_cidb.py).

Assigning to the author of the suspicious CL.

Comment 2 by akes...@chromium.org, Nov 19 

I hit this as well. Can we chump the revert?

Comment 3 by dburger@google.com, Nov 19 

I think yes, good idea, however, Alex said his revert is in the current CQ run:

https://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8929400792465570048

Is it possible this is going to complete successfully soon?
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a0d56b9237b01b5422c392806e068ad52b997d71

commit a0d56b9237b01b5422c392806e068ad52b997d71
Author: Alex Zamorzaev <zamorzaev@chromium.org>
Date: Tue Nov 20 07:43:54 2018

Revert "Remove waterfall parameter from InsertBuild method"

This reverts commit f227055565884dc43e0496ffc48a985726e24393.

Reason for revert: breaks chromeos-infra-unittests-pre-cq

BUG= chromium:906295 
TEST=None

Original change's description:
> Remove waterfall parameter from InsertBuild method
>
> Part of reducing the waterfall concept and the usage of
> the constants out of waterfall.py - remove waterfall as
> a parameter from the cidb InsertBuild call as all builds
> are now swarming builds and the waterfall column is left
> blank.
>
> TEST=lib/cidb_integration_test --debug --no-wipe
> TEST=chromite/run_tests
> BUG=836551
>
> Change-Id: Ie537ce3a6cd96ddf4d79fd8bddad20e97b4df259
> Reviewed-on: https://chromium-review.googlesource.com/1336004
> Commit-Ready: David Burger <dburger@chromium.org>
> Tested-by: David Burger <dburger@chromium.org>
> Reviewed-by: Don Garrett <dgarrett@chromium.org>

Change-Id: I068c2f06a4a628bac101752196d5ea9f797ac5eb
Reviewed-on: https://chromium-review.googlesource.com/1341120
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Don Garrett <dgarrett@chromium.org>
Reviewed-by: Alex Zamorzaev <zamorzaev@chromium.org>

[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/build_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/clactions_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/cidb_integration_test.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/report_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/cidb.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/relevant_changes_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/validation_pool_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/hwtest_results_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/sync_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/builders/generic_builders_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/scripts/summarize_build_stats_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/test_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/fake_cidb.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/builder_status_lib_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/generic_stages_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/report_stages.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/lib/clactions_metrics_unittest.py
[modify] https://crrev.com/a0d56b9237b01b5422c392806e068ad52b997d71/cbuildbot/stages/handle_changes_stages_unittest.py
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 22 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/0d55bcab63bea4816e536ec78c533ec08d8033f9

commit 0d55bcab63bea4816e536ec78c533ec08d8033f9
Author: David Burger <dburger@chromium.org>
Date: Thu Nov 22 06:49:19 2018

Add chromeos-infra-unittests-pre-cq to list of pre-cq builders

Add chromeos-infra-unittests-pre-cq to list of pre-cq builders as the
chromite code is undergoing heavy churn at this time, partially due
to removal of waterfall specific code (see bug), and including this
builder in the pre-cq runs will help prevent breaking changes from
making it through the CQ.

TEST=None
BUG= chromium:906295 

Change-Id: I65da30153178a28ea13a34e2410c87163685b69c
Reviewed-on: https://chromium-review.googlesource.com/1343422
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: David Burger <dburger@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/0d55bcab63bea4816e536ec78c533ec08d8033f9/COMMIT-QUEUE.ini

Comment 6 by ayatane@chromium.org, Nov 27

Status: Fixed (was: Untriaged)
►

Sign in to add a comment