Issue metadata
Sign in to add a comment
|
15.8% regression in media_perftests at 607966:608127 |
||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Nov 16
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14a944f7e40000
,
Nov 17
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/14a944f7e40000 Constexpr-eliminate GetCategoryGroupEnabled calls for popular categories by alexilin@chromium.org https://chromium.googlesource.com/chromium/src/+/331266377d03b51dc3e2cf2c26b896e21f8f0391 vector_math_fmac: 652.5 → 607.6 (-44.87) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Nov 17
Alex, any chance that this regression is because of your code? (Seems a bit unlikely to me.)
,
Nov 19
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/16a89924140000
,
Nov 19
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/16a89924140000 All of the runs failed. The most common error (10/20 runs) was: HTTPException: HTTP status code 400: {"error": {"message": "CIPD package path is required. Use \".\" to install to run dir."}}
,
Nov 19
Yeah, it looks unlikely to me as well, given that media_perftests doesn't produce any trace events. I started another bisect, let's look at what it will find.
,
Nov 20
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/171c458fe40000
,
Nov 20
📍 Found a significant difference after 1 commit. https://pinpoint-dot-chromeperf.appspot.com/job/171c458fe40000 Constexpr-eliminate GetCategoryGroupEnabled calls for popular categories by alexilin@chromium.org https://chromium.googlesource.com/chromium/src/+/331266377d03b51dc3e2cf2c26b896e21f8f0391 vector_math_fmac: 652 → 607.6 (-44.39) Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Nov 22
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/17c6bd38140000
,
Nov 22
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/17c6bd38140000 All of the runs failed. The most common error (20/20 runs) was: SwarmingTaskError: The swarming task failed with state "BOT_DIED".
,
Nov 22
📍 Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/10d5f34be40000
,
Nov 22
😿 Pinpoint job stopped with an error. https://pinpoint-dot-chromeperf.appspot.com/job/10d5f34be40000 All of the runs failed. The most common error (20/20 runs) was: SwarmingTaskError: The swarming task failed with state "BOT_DIED".
,
Nov 22
I checked that the code generated for the function being tested (media::vector_math::FMAC_SSE) is identical before and after the patch % addresses. Have no idea where the performance difference comes from. It may be related to less effective cache utilization. Understanding the reason of the previous improvement from this graph may help. I filed the Issue 907871.
,
Dec 3
I took a look at this, but I'm as stumped as you are. My best guess is that the tested code ends up crossing a page boundary with your code, and the extra page faults is causing it to execute slower. Either way, I'm going to assign it to you since your Cl does seem to be involved somehow, if perhaps only incidentally. Maybe closing it as WontFix would be better though... |
|||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Nov 16