New issue
Advanced search Search tips

Issue 906269 link

Starred by 2 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Regression: kerberos smb share authentication no longer works in 71

Project Member Reported by baileyberro@google.com, Nov 16

Issue description

In M71, authentication with kerberos is broken when using SMB URIs of the form //server/share. This feature worked in M70 and has become a cause for confusion with enterprise customers.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0e229191ab76a528f607e5f564fb431cbe43e489

commit 0e229191ab76a528f607e5f564fb431cbe43e489
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Nov 20 00:39:21 2018

Convert all unresolved hostnames to cannonical format

For chromad kerberos users, we do not resolve mount paths and instead
rely on the domain controller to resolve it. This CL fixes a bug where
windows URIs were not converted to the cannoncial smb:// format that is
expected by libsmbclient resulting in an INVALID_OPERATION error.

Bug: chromium:906269
Change-Id: I363e9375a32d2d0d6a990c0fdaab11a4aced064a
Reviewed-on: https://chromium-review.googlesource.com/c/1341022
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609532}
[modify] https://crrev.com/0e229191ab76a528f607e5f564fb431cbe43e489/chrome/browser/chromeos/smb_client/smb_service.cc

Labels: Merge-Request-71
This is a regression in 71 where we don't accept the expected/requested URL format. It's been reported in two customer interactions.

The fix is a single line and safe and has already been tested.

Unfortunately this also affects how the enterprise policy for this feature works because URLs can be sent via policy.

If there's a way to get this into 71 that would be great.
Project Member

Comment 3 by sheriffbot@chromium.org, Nov 27

Labels: -Merge-Request-71 Hotlist-Merge-Review Merge-Review-71
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-71 Merge-Approved-71
Approving merge to M71 Chrome OS.  Thanks for the description and testing details.
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 29

Labels: -merge-approved-71 merge-merged-3578
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e91b1c798e7c85462d1baf429d3bf6bb0b722a02

commit e91b1c798e7c85462d1baf429d3bf6bb0b722a02
Author: Bailey Berro <baileyberro@chromium.org>
Date: Thu Nov 29 01:45:41 2018

Convert all unresolved hostnames to cannonical format

For chromad kerberos users, we do not resolve mount paths and instead
rely on the domain controller to resolve it. This CL fixes a bug where
windows URIs were not converted to the cannoncial smb:// format that is
expected by libsmbclient resulting in an INVALID_OPERATION error.

Bug: chromium:906269
Change-Id: I363e9375a32d2d0d6a990c0fdaab11a4aced064a
Reviewed-on: https://chromium-review.googlesource.com/c/1341022
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#609532}(cherry picked from commit 0e229191ab76a528f607e5f564fb431cbe43e489)
Reviewed-on: https://chromium-review.googlesource.com/c/1354656
Cr-Commit-Position: refs/branch-heads/3578@{#843}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
[modify] https://crrev.com/e91b1c798e7c85462d1baf429d3bf6bb0b722a02/chrome/browser/chromeos/smb_client/smb_service.cc

Labels: Merge-Merged-71-3578
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/e91b1c798e7c85462d1baf429d3bf6bb0b722a02

Commit: e91b1c798e7c85462d1baf429d3bf6bb0b722a02
Author: baileyberro@chromium.org
Commiter: zentaro@chromium.org
Date: 2018-11-29 01:45:41 +0000 UTC

Convert all unresolved hostnames to cannonical format

For chromad kerberos users, we do not resolve mount paths and instead
rely on the domain controller to resolve it. This CL fixes a bug where
windows URIs were not converted to the cannoncial smb:// format that is
expected by libsmbclient resulting in an INVALID_OPERATION error.

Bug: chromium:906269
Change-Id: I363e9375a32d2d0d6a990c0fdaab11a4aced064a
Reviewed-on: https://chromium-review.googlesource.com/c/1341022
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#609532}(cherry picked from commit 0e229191ab76a528f607e5f564fb431cbe43e489)
Reviewed-on: https://chromium-review.googlesource.com/c/1354656
Cr-Commit-Position: refs/branch-heads/3578@{#843}
Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}

Sign in to add a comment