Two PDF BlockedSchemeNavigationBrowserTests failing on Site Isolation Android |
||
Issue descriptionThe two tests are: BlockedSchemeNavigationBrowserTest.PDF_NavigationFromFrame_TopFrameHasBlockedScheme_Block/1 BlockedSchemeNavigationBrowserTest.PDF_NavigationFromFrame_Block Sample failing build: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Site%20Isolation%20Android/27289 Looks like the tests are timing out on the Site Isolation Android FYI bot, which just runs them with --site-per-process. The tests already seem to have a separate codepath for Android, though I haven't checked where things start failing. meacer@: looks like you added these tests in r554850. Would you be able to take a look? It would be important to not regress your top-frame navigation blocking logic when we ship some form of site isolation for Android.
,
Dec 3
Not blocking, but would it be possible to fix this in the M73 timeframe, so we don't regress this when launching site isolation for Android?
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5b43ee7a5dcc3b907a345051250affd026105e2c commit 5b43ee7a5dcc3b907a345051250affd026105e2c Author: Alex Moshchuk <alexmos@chromium.org> Date: Fri Dec 07 22:35:31 2018 Disable currently failing tests on Site Isolation Android FYI bot. Bug: 906247, 906256 Change-Id: Idd03ac55d3ce92c14099023dd2df84c0edc88b14 Reviewed-on: https://chromium-review.googlesource.com/c/1365982 Reviewed-by: Ćukasz Anforowicz <lukasza@chromium.org> Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#614848} [modify] https://crrev.com/5b43ee7a5dcc3b907a345051250affd026105e2c/testing/buildbot/chromium.fyi.json [add] https://crrev.com/5b43ee7a5dcc3b907a345051250affd026105e2c/testing/buildbot/filters/site_isolation_android.content_browsertests.filter [modify] https://crrev.com/5b43ee7a5dcc3b907a345051250affd026105e2c/testing/buildbot/test_suites.pyl
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this. |
||
►
Sign in to add a comment |
||
Comment 1 by mea...@chromium.org
, Dec 3