New issue
Advanced search Search tips

Issue 906253 link

Starred by 1 user
Status: Fixed
Owner:
dvadym@chromium.org
Closed: Nov 26
Cc:
dvadym@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Bug-Regression

Blocking:
issue 777268
issue 831123



Sign in to add a comment

Automatic save-password prompt seen after manual save

Project Member Reported by vabr@chromium.org, Nov 16 
Chrome Version       : 72.0.3613.0
OS: Linux
URLs (if applicable) : https://rsolomakhin.github.io/autofill/

What steps will reproduce the problem?
0. Start Chrome with --enable-features=new-password-form-parsing
1. Go to https://rsolomakhin.github.io/autofill/, fill the password form.
2. Use the key icon to manually save before submitting.
3. Submit the form.

What is the expected result?
No automatic save-prompt pops up, because the password is already saved.

What happens instead of that?
The automatic prompt does pop up, clicking Save apparently attempts to save the credentials again: SQL errors about duplicate unique key are seen in the logs:
[238211:238469:1116/234056.920804:ERROR:database.cc(1829)] Passwords sqlite error 2067, errno 0: UNIQUE constraint failed: (...)

Comment 1 by battre@chromium.org, Nov 19

Blocking: 596849
Labels: -Type-Bug Type-Bug-Regression

Comment 2 by vabr@chromium.org, Nov 19

Blocking: 777268
Thanks for fixing the type, Dominic.
Did you mean to make this block another bug? Bug 596849 seems unrelated.

Comment 3 by dvadym@chromium.org, Nov 19

Owner: dvadym@chromium.org
Status: Started (was: Available)

Comment 4 by battre@chromium.org, Nov 19

Blocking: -596849 831123
no, certainly not. meant bug 831123
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52aaea792f67d5944c6dc822ae7e062cad957281

commit 52aaea792f67d5944c6dc822ae7e062cad957281
Author: Vadym Doroshenko <dvadym@chromium.org>
Date: Mon Nov 19 18:33:59 2018

PasswordManager should update all PasswordFormManagers.

Now if the new parsing is on PasswordManager doesn't update
PasswordFormManagers. That's wrong since they are used for saving and
for comparing with NewPasswordFormManagers. This CL fixes that.

Bug:  906253 , 831123
Change-Id: I35e16993126699d86e89e2ab6519b7be335f3e04
Reviewed-on: https://chromium-review.googlesource.com/c/1341990
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609359}
[modify] https://crrev.com/52aaea792f67d5944c6dc822ae7e062cad957281/components/password_manager/core/browser/password_manager.cc
[modify] https://crrev.com/52aaea792f67d5944c6dc822ae7e062cad957281/components/password_manager/core/browser/password_manager_unittest.cc

Comment 6 by dvadym@chromium.org, Nov 26

Status: Fixed (was: Started)
►

Sign in to add a comment