New issue
Advanced search Search tips

Issue 906251 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature

Blocked on:
issue 906237



Sign in to add a comment

Switch to use the new data format for chromeperf

Project Member Reported by pwang@chromium.org, Nov 16

Issue description

Based on crbug.com/905069 #8, chromeperf is moving to use /add_histograms instead of the old /add_points

The new data format
http://cs/chromeos_public/src/third_party/autotest/files/tko/perf_upload/perf_uploader.py?l=32

Chart json format to histogram format converter 
https://github.com/catapult-project/catapult/blob/master/tracing/bin/chartjson2histograms.py

ChromeOS perf_uploader
https://cs.corp.google.com/chromeos_public/src/third_party/autotest/files/tko/perf_upload/perf_uploader.py?q=perf_uploader&dr=C&l=38

Ben@ Does /add_histogram only accept the new data format or it accept the old chart JSON format as well?
 
Summary: Switch to use the new data format for chromeperf (was: Switch to use the new data format)
/add_histograms only accepts HistogramSet json.
https://github.com/catapult-project/catapult/blob/master/docs/histogram-set-json-format.md

You can use this script to convert chartjson to histograms:
https://cs.chromium.org/chromium/src/third_party/catapult/tracing/bin/chartjson2histograms.py

Eventually, it would be best if the tests/scripts could be updated to generate Histograms directly. That will allow them to add Breakdowns, RelatedNameMaps, and other diagnostics. Here are JS and Python implementations of Histograms, and we expect to have a C++ implementation next year.
https://cs.chromium.org/chromium/src/third_party/catapult/tracing/tracing/value/

You can either test uploading to production (chromeperf.appspot.com), or you can test uploading using dev_appserver. See instructions in this CL description:
https://chromium-review.googlesource.com/c/catapult/+/1316008

Owner: pwang@chromium.org
Status: Assigned (was: Untriaged)
I tried to setup local dev_appserver for testing but lots of dependency problem pops up.....
Some playing with the chartjson2histograms.py and our POST data, https://docs.google.com/document/d/1rlYLKhpX-dpO4r77VjtKFDorFbwhWhEY6ypkKHnyGLQ/edit?usp=sharing

Sign in to add a comment