New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 906247 link

Starred by 2 users
Status: Assigned
Owner:
gab@chromium.org
Cc:
lukasza@chromium.org
alex...@chromium.org
█ nasko@chromium.org
wfh@chromium.org
creis@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

RenderFrameHostManagerTest.ForegroundNavigationIsNeverBackgroundedWithSpareProcess is failing on Site Isolation Android

Project Member Reported by alex...@chromium.org, Nov 16 
Sample failing build:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Site%20Isolation%20Android/27289

Sample output:
[ RUN      ] RenderFrameHostManagerTest.ForegroundNavigationIsNeverBackgroundedWithSpareProcess
[WARNING:dns_config_service_posix.cc(334)] Failed to read DnsConfig.
referenceTable head length=54 1
../../content/browser/frame_host/render_frame_host_manager_browsertest.cc:5353: Failure
Value of: spare_rph->IsProcessBackgrounded()
  Actual: true
Expected: false
Stack trace:

[  FAILED  ] RenderFrameHostManagerTest.ForegroundNavigationIsNeverBackgroundedWithSpareProcess, where TypeParam =  and GetParam() =  (605 ms)
[----------] 1 test from RenderFrameHostManagerTest (605 ms total)

nasko@ / gab@ - can you please take a look, since I think you worked on this test (r587403) for  issue 560446 ?  I'm curious why this test behaves differently on Android, and whether it's indicating that there's a possible priority problem there.

also +lukasza@ for spare process knowledge.

Comment 1 by nasko@chromium.org, Nov 16

Cc: -gab@chromium.org nasko@chromium.org
Owner: gab@chromium.org
Passing off to gab@ as he did the under-the-hood changes and to avoid starvation, since I will be out of office soon for a longish period of time.
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b43ee7a5dcc3b907a345051250affd026105e2c

commit 5b43ee7a5dcc3b907a345051250affd026105e2c
Author: Alex Moshchuk <alexmos@chromium.org>
Date: Fri Dec 07 22:35:31 2018

Disable currently failing tests on Site Isolation Android FYI bot.

Bug: 906247, 906256
Change-Id: Idd03ac55d3ce92c14099023dd2df84c0edc88b14
Reviewed-on: https://chromium-review.googlesource.com/c/1365982
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#614848}
[modify] https://crrev.com/5b43ee7a5dcc3b907a345051250affd026105e2c/testing/buildbot/chromium.fyi.json
[add] https://crrev.com/5b43ee7a5dcc3b907a345051250affd026105e2c/testing/buildbot/filters/site_isolation_android.content_browsertests.filter
[modify] https://crrev.com/5b43ee7a5dcc3b907a345051250affd026105e2c/testing/buildbot/test_suites.pyl

Comment 3 by alex...@chromium.org, Jan 9

Labels: -Pri-3 Pri-2
Status: Assigned (was: Untriaged)
gab@: any updates here?  Curious if this test failure might be indicating a possible perf problem for site isolation on Android, and if this is something we should fix before launching it.

Comment 4 by gab@chromium.org, Jan 17 (6 days ago) 

Sorry, feel free to pick this up, I will try to have a look this Q otherwise as part of making BoostForPendingViews the default everywhere (which currently also makes Android unhappy : https://chromium-review.googlesource.com/c/chromium/src/+/1334295).
►

Sign in to add a comment