We have simpler ways of doing integration testing for services. ServiceTest is super heavyweight and hard to use. It's also not used in many places anymore. Let's delete it.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b commit 4351326902fd7ffeb09c9377f52e0d3a81fd6c7b Author: Ken Rockot <rockot@google.com> Date: Tue Nov 20 21:46:10 2018 Move some Chrome OS services off ServiceContext This switches the IME and Assistant services to use ServiceBinding instead of deprecated ServiceContext & EmbeddedService APIs. Also moves their tests off of the deprecated ServiceTest framework and changes them to be simple unit tests. TBR=dcheng@chromium.org Bug: 891780 , 906239 Change-Id: I047fd3879da1c4eb89643717cd3d247cf638ef9b Reviewed-on: https://chromium-review.googlesource.com/c/1343037 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Leo Zhang <googleo@chromium.org> Reviewed-by: Tao Wu <wutao@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#609812} [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chrome/browser/profiles/profile_impl.h [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/BUILD.gn [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/assistant/BUILD.gn [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/assistant/OWNERS [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/assistant/service.cc [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/assistant/service.h [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/assistant/service_unittest.cc [delete] https://crrev.com/5d27769389586ad3adc1436f14589aa42c77c89d/chromeos/services/assistant/unittest_manifest.json [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/ime/BUILD.gn [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/ime/OWNERS [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/ime/ime_service.cc [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/ime/ime_service.h [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/chromeos/services/ime/ime_service_unittest.cc [delete] https://crrev.com/5d27769389586ad3adc1436f14589aa42c77c89d/chromeos/services/ime/test_manifest.json [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/content/browser/browser_context.cc [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/content/common/service_manager/service_manager_connection_impl.cc [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/content/common/service_manager/service_manager_connection_impl.h [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/content/public/browser/browser_context.h [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/content/public/common/service_manager_connection.h [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/services/service_manager/public/cpp/test/test_connector_factory.cc [modify] https://crrev.com/4351326902fd7ffeb09c9377f52e0d3a81fd6c7b/services/service_manager/public/cpp/test/test_connector_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e6fa6c5823cc39462904ebe7194878caec6179ec commit e6fa6c5823cc39462904ebe7194878caec6179ec Author: Ken Rockot <rockot@google.com> Date: Tue Nov 20 21:53:39 2018 More migration from ServiceContext & ServiceTest Migrates some miscellaneous stuff from ServiceContext and ServiceTest over to ServiceBinding and plain old unit tests. Introduces new TestService and TestServiceManager helpers for such unit tests to use. This ultimately provides similar functionality to the old ServiceTest framework but with much less hidden magic and only a marginal increase in per-test boilerplate. Bug: 895616, 906239 Change-Id: I5c4958f92092ee435efe2c83eaa371f1171a71d4 Reviewed-on: https://chromium-review.googlesource.com/c/1343372 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#609814} [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/ash/app_launch_unittest.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/ash/ash_service_unittest.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/ash/components/quick_launch/main.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/ash/components/quick_launch/quick_launch_application.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/ash/components/quick_launch/quick_launch_application.h [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/ash/shell/content/client/shell_main_delegate.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/chrome/utility/mash_service_factory.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/chrome/utility/mash_service_factory.h [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/filesystem/BUILD.gn [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/filesystem/file_system_app.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/filesystem/file_system_app.h [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/filesystem/files_test_base.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/filesystem/files_test_base.h [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/filesystem/main.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/font/BUILD.gn [delete] https://crrev.com/304f3ee41537a07c9f6d28b3ce6b31296b5cbe13/components/services/font/font_loader_test.h [rename] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/font/font_loader_unittest.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/font/font_service_app.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/font/font_service_app.h [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/font/main.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/leveldb/BUILD.gn [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/leveldb/leveldb_app.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/leveldb/leveldb_app.h [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/leveldb/leveldb_service_unittest.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/leveldb/main.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/components/services/leveldb/remote_iterator_unittest.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/content/test/BUILD.gn [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/services/service_manager/public/cpp/service_binding.cc [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/services/service_manager/public/cpp/test/BUILD.gn [add] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/services/service_manager/public/cpp/test/test_service.cc [add] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/services/service_manager/public/cpp/test/test_service.h [add] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/services/service_manager/public/cpp/test/test_service_manager.cc [add] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/services/service_manager/public/cpp/test/test_service_manager.h [modify] https://crrev.com/e6fa6c5823cc39462904ebe7194878caec6179ec/services/service_manager/service_manager.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b4dc618f2e412e7c29b261316002f80cfc41f59e commit b4dc618f2e412e7c29b261316002f80cfc41f59e Author: Ken Rockot <rockot@chromium.org> Date: Thu Nov 22 07:46:06 2018 Move pdf_compositor off ServiceContext/ServiceTest Migrates pdf_compositor from ServiceContext to ServiceBinding and makes its tests regular unit tests instead of using the deprecated ServiceTest framework. TBR=thestig@chromium.org Bug: 891780 , 906239 Change-Id: Ia2485320e71352b3263108544fbea06c6b8ca6ef Reviewed-on: https://chromium-review.googlesource.com/c/1343506 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: Wei Li <weili@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#610340} [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/chrome/utility/chrome_content_utility_client.cc [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/components/services/pdf_compositor/BUILD.gn [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/components/services/pdf_compositor/OWNERS [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/components/services/pdf_compositor/pdf_compositor_service.cc [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/components/services/pdf_compositor/pdf_compositor_service.h [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/components/services/pdf_compositor/pdf_compositor_service_unittest.cc [delete] https://crrev.com/1c8d73b56bafcbf0df5cbc2b5361b2fe3549bf16/components/services/pdf_compositor/pdf_compositor_service_unittest_manifest.json [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/components/services/pdf_compositor/public/cpp/pdf_compositor_service_factory.cc [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/components/services/pdf_compositor/public/cpp/pdf_compositor_service_factory.h [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/components/test/BUILD.gn [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/components/test/run_all_unittests.cc [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/headless/lib/utility/headless_content_utility_client.cc [modify] https://crrev.com/b4dc618f2e412e7c29b261316002f80cfc41f59e/headless/lib/utility/headless_content_utility_client.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9 commit 3d8be74a2fb8321ad0abb54a2d776b94b329e2f9 Author: Ken Rockot <rockot@chromium.org> Date: Thu Nov 22 08:59:38 2018 Move media and shape_detection to new service APIs Migrates three services (media, cdm, and shape_detection) away from some deprecated service APIs and onto new ones. Namely ServiceBinding and ServiceKeepalive are used in lieu of ServiceContext and ServiceContextRef, and regular unit tests are used instead of the deprecated ServiceTest framework. Bug: 891780 , 906239 Change-Id: I3302f35747702ae8cf39f6f1e33b416e3ec180b2 Reviewed-on: https://chromium-review.googlesource.com/c/1344882 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Robert Sesek <rsesek@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Reviewed-by: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610352} [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/chrome/browser/chrome_content_browser_client.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/chromecast/browser/cast_content_browser_client.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/chromecast/browser/cast_content_browser_client.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/browser/service_manager/service_manager_context.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/child/service_factory.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/child/service_factory.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/gpu/BUILD.gn [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/gpu/gpu_service_factory.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/gpu/gpu_service_factory.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/public/browser/content_browser_client.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/public/browser/content_browser_client.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/shell/browser/shell_content_browser_client.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/shell/browser/shell_content_browser_client.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/content/utility/utility_service_factory.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/ipc/run_all_unittests.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/BUILD.gn [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/OWNERS [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/cdm_service.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/cdm_service.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/cdm_service_unittest.cc [delete] https://crrev.com/06044295da62f4caf5196b73caef1e55b2ca4884/media/mojo/services/cdm_service_unittest_manifest.json [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/interface_factory_impl.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/interface_factory_impl.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/main.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/media_service.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/media_service.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/media_service_factory.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/media_service_factory.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/mojo/services/media_service_unittest.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/test/BUILD.gn [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/media/test/pipeline_integration_test.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/mojo/core/embedder/BUILD.gn [add] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/mojo/core/embedder/default_mach_broker.cc [add] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/mojo/core/embedder/default_mach_broker.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/mojo/core/test/mojo_test_base.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/mojo/core/test/multiprocess_test_helper.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/mojo/core/test/run_all_unittests.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/service_manager/public/cpp/service.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/service_manager/public/cpp/service.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/service_manager/public/cpp/service_keepalive.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/service_manager/public/cpp/standalone_service/BUILD.gn [delete] https://crrev.com/06044295da62f4caf5196b73caef1e55b2ca4884/services/service_manager/public/cpp/standalone_service/mach_broker.cc [delete] https://crrev.com/06044295da62f4caf5196b73caef1e55b2ca4884/services/service_manager/public/cpp/standalone_service/mach_broker.h [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/service_manager/public/cpp/standalone_service/standalone_service.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/service_manager/public/cpp/test/common_initialization.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/service_manager/runner/host/BUILD.gn [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/service_manager/runner/host/service_process_launcher.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/service_manager/standalone/context.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/shape_detection/shape_detection_service.cc [modify] https://crrev.com/3d8be74a2fb8321ad0abb54a2d776b94b329e2f9/services/shape_detection/shape_detection_service.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4 commit a7291ad30a9e5d27de42857e013f2bfbcebb2cb4 Author: Ken Rockot <rockot@chromium.org> Date: Thu Nov 22 11:03:18 2018 Move audio service to new service APIs Migrates audio service and related test code away from using deprecated service APIs (ServiceContext, ServiceTest, etc) in favor of better ones. Bug: 891780 , 906239 Change-Id: Iba655baf597fabd85fc0151d89cd32cb4b92578f Reviewed-on: https://chromium-review.googlesource.com/c/1345548 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Olga Sharonova <olka@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#610373} [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/content/utility/utility_service_factory.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/content/utility/utility_service_factory.h [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/BUILD.gn [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/BUILD.gn [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/public/cpp/fake_system_info.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/public/cpp/fake_system_info.h [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/service.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/service.h [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/service_factory.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/service_factory.h [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/service_main.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/test/debug_recording_session_unittest.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/test/in_process_service_test.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/test/service_lifetime_connector_test.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/test/service_lifetime_test_template.h [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/audio/test/standalone_service_test.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/service_manager/public/cpp/service_binding.cc [modify] https://crrev.com/a7291ad30a9e5d27de42857e013f2bfbcebb2cb4/services/service_manager/public/cpp/service_binding.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/91fe95840ad4fd2f168a02209409b8c2baaed80d commit 91fe95840ad4fd2f168a02209409b8c2baaed80d Author: Geoff Lang <geofflang@chromium.org> Date: Thu Nov 22 16:31:58 2018 Revert "Move audio service to new service APIs" This reverts commit a7291ad30a9e5d27de42857e013f2bfbcebb2cb4. Reason for revert: assertion failures on GPU FYI bots. BUG= 907898 Original change's description: > Move audio service to new service APIs > > Migrates audio service and related test code away from using deprecated > service APIs (ServiceContext, ServiceTest, etc) in favor of better ones. > > Bug: 891780 , 906239 > Change-Id: Iba655baf597fabd85fc0151d89cd32cb4b92578f > Reviewed-on: https://chromium-review.googlesource.com/c/1345548 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610373} TBR=kinuko@chromium.org,rockot@google.com,olka@chromium.org Change-Id: Ic96583fb5bbf549e5854276786afef4b7040dd70 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891780 , 906239 Reviewed-on: https://chromium-review.googlesource.com/c/1348252 Reviewed-by: Geoff Lang <geofflang@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#610436} [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/content/utility/utility_service_factory.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/content/utility/utility_service_factory.h [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/BUILD.gn [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/BUILD.gn [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/public/cpp/fake_system_info.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/public/cpp/fake_system_info.h [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/service.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/service.h [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/service_factory.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/service_factory.h [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/service_main.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/test/debug_recording_session_unittest.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/test/in_process_service_test.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/test/service_lifetime_connector_test.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/test/service_lifetime_test_template.h [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/audio/test/standalone_service_test.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/service_manager/public/cpp/service_binding.cc [modify] https://crrev.com/91fe95840ad4fd2f168a02209409b8c2baaed80d/services/service_manager/public/cpp/service_binding.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73dd78f19ce3881695ddd984dc9ed8adba11480e commit 73dd78f19ce3881695ddd984dc9ed8adba11480e Author: Ken Rockot <rockot@google.com> Date: Tue Nov 27 18:33:42 2018 Reland "Move audio service to new service APIs" This is a reland of a7291ad30a9e5d27de42857e013f2bfbcebb2cb4 Original change's description: > Move audio service to new service APIs > > Migrates audio service and related test code away from using deprecated > service APIs (ServiceContext, ServiceTest, etc) in favor of better ones. > > Bug: 891780 , 906239 > Change-Id: Iba655baf597fabd85fc0151d89cd32cb4b92578f > Reviewed-on: https://chromium-review.googlesource.com/c/1345548 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: Olga Sharonova <olka@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#610373} TBR=kinuko@chromium.org TBR=olka@chromium.org Bug: 891780 , 906239 Change-Id: I300692ee9b4e6b26a9957944b38ddf8f468b165a Reviewed-on: https://chromium-review.googlesource.com/c/1348629 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#611207} [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/content/utility/utility_service_factory.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/content/utility/utility_service_factory.h [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/BUILD.gn [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/BUILD.gn [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/public/cpp/fake_system_info.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/public/cpp/fake_system_info.h [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/service.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/service.h [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/service_factory.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/service_factory.h [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/service_main.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/test/debug_recording_session_unittest.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/test/in_process_service_test.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/test/service_lifetime_connector_test.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/test/service_lifetime_test_template.h [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/audio/test/standalone_service_test.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/service_manager/public/cpp/service_binding.cc [modify] https://crrev.com/73dd78f19ce3881695ddd984dc9ed8adba11480e/services/service_manager/public/cpp/service_binding.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afad685369a526d99fce89d7611fbddb5a27a909 commit afad685369a526d99fce89d7611fbddb5a27a909 Author: Ken Rockot <rockot@google.com> Date: Tue Nov 27 22:29:32 2018 Move device service to new service APIs Migrates device service code and tests from deprecated service APIs to new ones. Namely this phases out its use of ServiceContext and ServiceTest in favor of ServiceBinding and plain old unit tests. Bug: 891780 , 906239 Change-Id: I7677134b5d11e7297b162bbb532dfabb810504d2 Reviewed-on: https://chromium-review.googlesource.com/c/1345124 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#611379} [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/chrome/browser/chromeos/login/hid_detection_browsertest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/content/browser/battery_monitor_browsertest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/content/browser/device_sensors/device_sensor_browsertest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/content/browser/generic_sensor/generic_sensor_browsertest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/content/browser/power_monitor_browsertest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/content/browser/vibration_browsertest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/extensions/browser/api/hid/hid_apitest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/extensions/browser/api/serial/serial_apitest.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/BUILD.gn [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/device/BUILD.gn [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/device/OWNERS [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/device/device_service.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/device/device_service.h [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/device/device_service_test_base.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/device/device_service_test_base.h [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/device/public/cpp/hid/fake_input_service_linux.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/device/public/cpp/hid/fake_input_service_linux.h [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/device/public/cpp/test/scoped_geolocation_overrider.cc [delete] https://crrev.com/0b35c5fd4f5950f7fba61d1eb5a6999392c17554/services/device/unittest_manifest.json [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/service_manager/public/cpp/service_binding.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/service_manager/public/cpp/service_binding.h [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/service_manager/public/cpp/service_context.cc [modify] https://crrev.com/afad685369a526d99fce89d7611fbddb5a27a909/services/service_manager/public/cpp/service_context.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4 commit 772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4 Author: Tim Schumann <tschumann@chromium.org> Date: Wed Nov 28 11:20:57 2018 Revert "Move device service to new service APIs" This reverts commit afad685369a526d99fce89d7611fbddb5a27a909. Reason for revert: Findit detected this with 87.7% confidence to be the culprit of GeolocationServiceUnitTest.GeolocationConfig flakiness. Bug: 909637 Original change's description: > Move device service to new service APIs > > Migrates device service code and tests from deprecated service APIs to > new ones. Namely this phases out its use of ServiceContext and > ServiceTest in favor of ServiceBinding and plain old unit tests. > > Bug: 891780 , 906239 > Change-Id: I7677134b5d11e7297b162bbb532dfabb810504d2 > Reviewed-on: https://chromium-review.googlesource.com/c/1345124 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611379} TBR=jam@chromium.org,rockot@google.com,blundell@chromium.org,tsepez@chromium.org Change-Id: I3619eef380d3e46736bf0966359d37e2808d97ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 891780 , 906239 Reviewed-on: https://chromium-review.googlesource.com/c/1352766 Reviewed-by: Tim Schumann <tschumann@chromium.org> Commit-Queue: Tim Schumann <tschumann@chromium.org> Cr-Commit-Position: refs/heads/master@{#611650} [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/chrome/browser/chromeos/login/hid_detection_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/battery_monitor_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/device_sensors/device_sensor_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/generic_sensor/generic_sensor_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/power_monitor_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/content/browser/vibration_browsertest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/extensions/browser/api/hid/hid_apitest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/extensions/browser/api/serial/serial_apitest.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/BUILD.gn [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/BUILD.gn [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/OWNERS [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/device_service.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/device_service.h [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/device_service_test_base.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/device_service_test_base.h [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/public/cpp/hid/fake_input_service_linux.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/public/cpp/hid/fake_input_service_linux.h [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/public/cpp/test/scoped_geolocation_overrider.cc [add] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/device/unittest_manifest.json [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/service_manager/public/cpp/service_binding.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/service_manager/public/cpp/service_binding.h [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/service_manager/public/cpp/service_context.cc [modify] https://crrev.com/772b72bf84dac33e9cf983eeeaf5b5c9b2885cd4/services/service_manager/public/cpp/service_context.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f463cdba0a7f66b9b955cb24c83fa44c290d23c1 commit f463cdba0a7f66b9b955cb24c83fa44c290d23c1 Author: Ken Rockot <rockot@google.com> Date: Thu Nov 29 00:06:38 2018 Reland "Move device service to new service APIs" This is a reland of afad685369a526d99fce89d7611fbddb5a27a909 Original change's description: > Move device service to new service APIs > > Migrates device service code and tests from deprecated service APIs to > new ones. Namely this phases out its use of ServiceContext and > ServiceTest in favor of ServiceBinding and plain old unit tests. > > Bug: 891780 , 906239 > Change-Id: I7677134b5d11e7297b162bbb532dfabb810504d2 > Reviewed-on: https://chromium-review.googlesource.com/c/1345124 > Commit-Queue: Ken Rockot <rockot@google.com> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Tom Sepez <tsepez@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#611379} TBR=jam@chromium.org TBR=blundell@chromium.org NOPRESUBMIT=true Bug: 891780 , 906239 Change-Id: I3d61c1d0229e04d10adc4bcfe9032a50d5238ced Reviewed-on: https://chromium-review.googlesource.com/c/1352805 Reviewed-by: Ken Rockot <rockot@google.com> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#611946} [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/chrome/browser/chromeos/login/bluetooth_host_pairing_browsertest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/chrome/browser/chromeos/login/hid_detection_browsertest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/chrome/browser/chromeos/login/screens/hid_detection_screen_browsertest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/content/browser/battery_monitor_browsertest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/content/browser/device_sensors/device_sensor_browsertest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/content/browser/generic_sensor/generic_sensor_browsertest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/content/browser/power_monitor_browsertest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/content/browser/vibration_browsertest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/extensions/browser/api/hid/hid_apitest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/extensions/browser/api/serial/serial_apitest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/BUILD.gn [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/BUILD.gn [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/OWNERS [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/device_service.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/device_service.h [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/device_service_test_base.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/device_service_test_base.h [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/geolocation/geolocation_service_unittest.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/public/cpp/hid/fake_input_service_linux.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/public/cpp/hid/fake_input_service_linux.h [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/device/public/cpp/test/scoped_geolocation_overrider.cc [delete] https://crrev.com/71f24f632bbef2989fbe6df44877da0395f06e69/services/device/unittest_manifest.json [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/service_manager/public/cpp/service_binding.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/service_manager/public/cpp/service_binding.h [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/service_manager/public/cpp/service_context.cc [modify] https://crrev.com/f463cdba0a7f66b9b955cb24c83fa44c290d23c1/services/service_manager/public/cpp/service_context.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dfa77fa7c754a91d93fa9df269201690da0240dd commit dfa77fa7c754a91d93fa9df269201690da0240dd Author: Ken Rockot <rockot@chromium.org> Date: Thu Nov 29 06:31:19 2018 Migrate misc services to new service APIs Migrates identity, network, and tracing services and their tests away from the deprecated ServiceContext API to ServiceBinding, and from the deprecated ServiceTest framework to regular unit tests. Bug: 891780 , 906239 Change-Id: I0abd81aa8096735e51d3a21b1a4e4b0fa51d6d66 Reviewed-on: https://chromium-review.googlesource.com/c/1351770 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Reviewed-by: Colin Blundell <blundell@chromium.org> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612067} [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/chrome/browser/profiles/profile_impl.h [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/content/utility/utility_service_factory.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/content/utility/utility_service_factory.h [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/ios/chrome/browser/browser_state/BUILD.gn [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/ios/chrome/browser/browser_state/chrome_browser_state_impl.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/ios/chrome/browser/browser_state/chrome_browser_state_impl.h [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/ios/chrome/browser/signin/BUILD.gn [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/ios/chrome/browser/signin/identity_service_creator.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/ios/chrome/browser/signin/identity_service_creator.h [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/ios/web/browser_state.mm [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/ios/web/public/browser_state.h [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/BUILD.gn [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/identity/BUILD.gn [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/identity/OWNERS [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/identity/identity_manager_impl_unittest.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/identity/identity_service.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/identity/identity_service.h [delete] https://crrev.com/94e3324cafafe4de80a191233e7988870b7b5cbc/services/identity/unittest_manifest.json [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/network/BUILD.gn [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/network/network_service.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/network/network_service.h [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/network/network_service_unittest.cc [delete] https://crrev.com/94e3324cafafe4de80a191233e7988870b7b5cbc/services/network/test/OWNERS [delete] https://crrev.com/94e3324cafafe4de80a191233e7988870b7b5cbc/services/network/test/service_unittest_manifest.json [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/service_manager/public/cpp/test/test_connector_factory.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/service_manager/public/cpp/test/test_connector_factory.h [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/tracing/BUILD.gn [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/tracing/OWNERS [delete] https://crrev.com/94e3324cafafe4de80a191233e7988870b7b5cbc/services/tracing/service_main.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/tracing/tracing_service.cc [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/tracing/tracing_service.h [modify] https://crrev.com/dfa77fa7c754a91d93fa9df269201690da0240dd/services/tracing/tracing_service_unittest.cc [delete] https://crrev.com/94e3324cafafe4de80a191233e7988870b7b5cbc/services/tracing/unittest_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b1ec545a3913d63da422a4b5467b79aafe708bfd commit b1ec545a3913d63da422a4b5467b79aafe708bfd Author: Ken Rockot <rockot@chromium.org> Date: Thu Nov 29 06:43:49 2018 Migrate resource_coordinator to new service APIs Migrates resource_coordinator away from the deprecated ServiceContext API to ServiceBinding, and migrates its tests from the deprecated ServiceTest framework to regular unit tests. Bug: 891780 , 906239 Change-Id: I308746a7fc02402ec78d59f03c2c06395bc79b5c Reviewed-on: https://chromium-review.googlesource.com/c/1351775 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612072} [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/content/browser/service_manager/service_manager_context.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/BUILD.gn [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/BUILD.gn [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/OWNERS [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/coordination_unit_base.h [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/coordination_unit_base_unittest.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/coordination_unit_graph.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/coordination_unit_graph.h [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/coordination_unit_provider_impl.h [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/coordination_unit_test_harness.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/coordination_unit_test_harness.h [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/frame_coordination_unit_impl.h [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/mock_coordination_unit_graphs.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/page_coordination_unit_impl.h [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/process_coordination_unit_impl.h [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/coordination_unit/system_coordination_unit_impl.h [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/resource_coordinator_service.cc [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/resource_coordinator_service.h [modify] https://crrev.com/b1ec545a3913d63da422a4b5467b79aafe708bfd/services/resource_coordinator/resource_coordinator_service_unittest.cc [delete] https://crrev.com/60740217befc62853f2205a1b5f282a64d55291b/services/resource_coordinator/service_main.cc [delete] https://crrev.com/60740217befc62853f2205a1b5f282a64d55291b/services/resource_coordinator/unittest_manifest.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/08750528fcc2ea75a6e97b0cae72dcc21cc2d782 commit 08750528fcc2ea75a6e97b0cae72dcc21cc2d782 Author: Ken Rockot <rockot@chromium.org> Date: Thu Nov 29 07:41:34 2018 Migrate prefs service to new service APIs Migrates prefs service away from the deprecated ServiceContext API to ServiceBinding, and migrates its tests from the deprecated ServiceTest framework to regular unit tests. Bug: 891780 , 906239 Change-Id: Id5d73b2aa6c87d40d3e9814946c91494a18afd66 Reviewed-on: https://chromium-review.googlesource.com/c/1351875 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612090} [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/chrome/browser/profiles/off_the_record_profile_impl.cc [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/chrome/browser/profiles/off_the_record_profile_impl.h [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/chrome/browser/profiles/profile_impl.cc [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/services/BUILD.gn [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/services/preferences/BUILD.gn [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/services/preferences/pref_service_factory_unittest.cc [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/services/preferences/pref_store_manager_impl.cc [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/services/preferences/pref_store_manager_impl.h [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/services/preferences/public/cpp/in_process_service_factory.cc [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/services/preferences/public/cpp/in_process_service_factory.h [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/services/preferences/public/cpp/pref_service_main.cc [modify] https://crrev.com/08750528fcc2ea75a6e97b0cae72dcc21cc2d782/services/preferences/public/cpp/pref_service_main.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd32b5d476d666d0ea390d42bbb49ee550fa9348 commit dd32b5d476d666d0ea390d42bbb49ee550fa9348 Author: Ken Rockot <rockot@chromium.org> Date: Thu Nov 29 09:34:23 2018 Migrate video_capture off of ServiceTest Migrates video_capture away from the deprecated ServiceTest framework to use regular unit tests and new test helpers provided by the Service Manager client library. Bug: 906239 Change-Id: I56f9a1ce396b601f4e6a5e9078c506398cf50dbc Reviewed-on: https://chromium-review.googlesource.com/c/1352750 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#612117} [modify] https://crrev.com/dd32b5d476d666d0ea390d42bbb49ee550fa9348/services/BUILD.gn [modify] https://crrev.com/dd32b5d476d666d0ea390d42bbb49ee550fa9348/services/video_capture/BUILD.gn [modify] https://crrev.com/dd32b5d476d666d0ea390d42bbb49ee550fa9348/services/video_capture/test/device_factory_provider_test.cc [modify] https://crrev.com/dd32b5d476d666d0ea390d42bbb49ee550fa9348/services/video_capture/test/device_factory_provider_test.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5 commit 1e51be809a1d7fb7768c61ee1f92eccc2e0563a5 Author: Ken Rockot <rockot@chromium.org> Date: Thu Nov 29 14:47:46 2018 Move ws and ime services off ServiceTest framework This migrates ws and related IME service tests away from the deprecated ServiceTest framework in favor of regular unit tests using newer Service Manager test helpers. Since this is the final set of tests which was using ServiceTest in services_unittests, the target is also replaced with a plain old gtest suite and the global catalog configuration junk is removed. Bug: 906239 Change-Id: Ic85c7be164fde2b6a9883d0af547600c71f446b5 Reviewed-on: https://chromium-review.googlesource.com/c/1352695 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#612187} [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/ash/shell/content/client/shell_main_delegate.cc [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/BUILD.gn [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/test/BUILD.gn [rename] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/test/run_all_unittests.cc [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/ws/BUILD.gn [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/ws/ime/BUILD.gn [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/ws/ime/ime_unittest.cc [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/ws/ime/test_ime_driver/main.cc [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/ws/ime/test_ime_driver/test_ime_application.cc [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/ws/ime/test_ime_driver/test_ime_application.h [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/ws/window_server_service_test_base.cc [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/ws/window_server_service_test_base.h [modify] https://crrev.com/1e51be809a1d7fb7768c61ee1f92eccc2e0563a5/services/ws/window_tree_client_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea36de23a23b66019410fc11aaced270db753c40 commit ea36de23a23b66019410fc11aaced270db753c40 Author: Ken Rockot <rockot@google.com> Date: Thu Nov 29 21:49:20 2018 [service-manager] Delete the ServiceTest framework This deletes all code supporting the deprecated ServiceTest framework and also cleans up a bunch of superfluous dependencies on service stuff around the tree. TBR=sky@chromium.org Bug: 906239 Change-Id: I56db6c5a4c1d0ffab1be5dde08692383c424d5b6 Reviewed-on: https://chromium-review.googlesource.com/c/1354507 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#612389} [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/ash/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chrome/services/app_service/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chrome/services/cups_ipp_parser/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chrome/services/file_util/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chrome/services/isolated_xr_device/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chrome/services/media_gallery_util/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chrome/services/printing/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chrome/services/util_win/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chrome/services/wifi_util_win/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chromeos/services/device_sync/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chromeos/services/device_sync/public/cpp/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chromeos/services/multidevice_setup/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chromeos/services/multidevice_setup/public/cpp/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/chromeos/services/secure_channel/public/cpp/client/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/components/mirroring/service/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/components/services/heap_profiling/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/components/services/patch/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/components/services/pdf_compositor/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/components/services/unzip/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/content/test/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/audio/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/catalog/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/data_decoder/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/file/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/media_session/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/proxy_resolver/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/background/tests/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/background/tests/background_service_manager_unittest.cc [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/public/cpp/BUILD.gn [delete] https://crrev.com/d496fcb4464964ce19683cc9e80a9c7f3ce5081d/services/service_manager/public/cpp/service_test.cc [delete] https://crrev.com/d496fcb4464964ce19683cc9e80a9c7f3ce5081d/services/service_manager/public/cpp/service_test.h [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/public/cpp/test/BUILD.gn [delete] https://crrev.com/d496fcb4464964ce19683cc9e80a9c7f3ce5081d/services/service_manager/public/cpp/test/common_initialization.cc [delete] https://crrev.com/d496fcb4464964ce19683cc9e80a9c7f3ce5081d/services/service_manager/public/cpp/test/common_initialization.h [delete] https://crrev.com/d496fcb4464964ce19683cc9e80a9c7f3ce5081d/services/service_manager/public/cpp/test/run_all_service_tests.cc [delete] https://crrev.com/d496fcb4464964ce19683cc9e80a9c7f3ce5081d/services/service_manager/public/cpp/test/service_test_catalog.h [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/public/cpp/test/test_service_manager.cc [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/public/cpp/test/test_service_manager.h [delete] https://crrev.com/d496fcb4464964ce19683cc9e80a9c7f3ce5081d/services/service_manager/public/tools/test/service_test.gni [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/connect/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/connect/connect_unittest.cc [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/lifecycle/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/lifecycle/lifecycle_unittest.cc [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/service_manager/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/service_manager/service_manager_listener_unittest.cc [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/service_manager/service_manager_unittest.cc [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/shutdown/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/service_manager/tests/shutdown/shutdown_unittest.cc [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/shape_detection/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/test/echo/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/test/user_id/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/viz/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/viz/privileged/interfaces/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/viz/public/cpp/compositing/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/ws/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/ws/gpu_host/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/ws/ime/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/services/ws/input_devices/BUILD.gn [modify] https://crrev.com/ea36de23a23b66019410fc11aaced270db753c40/ui/views/mus/BUILD.gn
Comment 1 by bugdroid1@chromium.org
, Nov 20