oobe_config failing in ASAN builder with memory leaks |
|||
Issue descriptionStarting around 7am on Nov 16, the asan builder started failing its unit test stage with memory leaks detectged in oobe_config See the link below for an example log: https://luci-logdog.appspot.com/logs/chromeos/buildbucket/cr-buildbucket.appspot.com/8929690641021257040/+/steps/UnitTest/0/stdout This is a regression and should be fixed asap.
,
Nov 16
,
Nov 18
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/90c9002ff805aa9a9ad9b0c6dcc7a5c79c0085e6 commit 90c9002ff805aa9a9ad9b0c6dcc7a5c79c0085e6 Author: Amin Hassani <ahassani@chromium.org> Date: Sun Nov 18 15:11:10 2018 oobe_config: Fix asan error with memory leak From the API it seems like base::Environment::Create() returns a unique_ptr, but even its unittests and some other examples are assuming it returns a raw pointer and it seems like the implementation is also returns a raw pointer and that's why we are getting a memory leak in the unittests. (Maybe we're still on an older version of libchrome?!) BUG= chromium:906228 TEST='USE=asan FEATURES=test emerge-edgar oobe_config' Change-Id: I440cd379986350e8175f67eaa187d114aefa2c5d Reviewed-on: https://chromium-review.googlesource.com/1340424 Commit-Ready: Amin Hassani <ahassani@chromium.org> Tested-by: Amin Hassani <ahassani@chromium.org> Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by: Caroline Tice <cmtice@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/90c9002ff805aa9a9ad9b0c6dcc7a5c79c0085e6/oobe_config/load_oobe_config_usb_test.cc [modify] https://crrev.com/90c9002ff805aa9a9ad9b0c6dcc7a5c79c0085e6/oobe_config/save_oobe_config_usb_test.cc
,
Dec 3
can this be closed?
,
Dec 3
,
Dec 3
yep, thanks :) |
|||
►
Sign in to add a comment |
|||
Comment 1 by ahass...@chromium.org
, Nov 16