New issue
Advanced search Search tips

Issue 906223 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Omnibox - Steady State Elisions - One Click Unelide

Project Member Reported by tommycli@google.com, Nov 16

Issue description

Omnibox - Steady State Elisions - One Click Unelide
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b20aec74c069efdd7bf253cf9c6d4d208dcf9770

commit b20aec74c069efdd7bf253cf9c6d4d208dcf9770
Author: Tommy C. Li <tommycli@chromium.org>
Date: Mon Nov 19 21:38:23 2018

Omnibox: Steady State Elisions - Implement One Click Unelide for Views

Add a flag chrome://flags/#omnibox-ui-one-click-unelide that performs
unelision whenever the omnibox is focused, via either keyboard, mouse,
or gesture tap.

This notably does not affect Query in Omnibox, as the user may still
want to refine the query.

Bug: 906223
Change-Id: Iac9028ed42c75302e280a9de8abce6ed4bb5edc5
Reviewed-on: https://chromium-review.googlesource.com/c/1340828
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609447}
[modify] https://crrev.com/b20aec74c069efdd7bf253cf9c6d4d208dcf9770/chrome/browser/about_flags.cc
[modify] https://crrev.com/b20aec74c069efdd7bf253cf9c6d4d208dcf9770/chrome/browser/flag-metadata.json
[modify] https://crrev.com/b20aec74c069efdd7bf253cf9c6d4d208dcf9770/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/b20aec74c069efdd7bf253cf9c6d4d208dcf9770/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/b20aec74c069efdd7bf253cf9c6d4d208dcf9770/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
[modify] https://crrev.com/b20aec74c069efdd7bf253cf9c6d4d208dcf9770/chrome/browser/ui/views/omnibox/omnibox_view_views.h
[modify] https://crrev.com/b20aec74c069efdd7bf253cf9c6d4d208dcf9770/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/b20aec74c069efdd7bf253cf9c6d4d208dcf9770/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/b20aec74c069efdd7bf253cf9c6d4d208dcf9770/tools/metrics/histograms/enums.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8a1133a0a03490e165640af6bc9dfd5d070c06ce

commit 8a1133a0a03490e165640af6bc9dfd5d070c06ce
Author: Tommy C. Li <tommycli@chromium.org>
Date: Mon Dec 03 19:55:50 2018

Omnibox: Make OmniboxView::GetIcon more robust for steady state elisions

Whenever the user unelides the URL, the omnibox also enters
user_input_in_progress_ mode.

This is was harmless before, but since then we have started displaying
suggestion favicons in the omnibox, the current page's security
indicator is being clobbered by the page's favicon during unelision.

This is not correct, since unelision is supposed to be as unobtrusive
as possible.

This is going to become more noticable now that Ctrl+L triggers
unelision, as well as our future planned work for One-Click-Unelide.

This CL replaces the old logic, and keeps showing the current page's
security indicator until the user actually modifies the user text.

Bug: 874592, 906223, 910145
Change-Id: I8a5619d4408b09d2e9f98fd5ce011ecbd2cab085
Reviewed-on: https://chromium-review.googlesource.com/c/1351564
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: Kevin Bailey <krb@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613203}
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/chrome/browser/ui/views/location_bar/location_bar_view.cc
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/location_bar_model.h
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/location_bar_model_impl.cc
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/omnibox_edit_model.cc
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/omnibox_edit_model.h
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/omnibox_edit_model_unittest.cc
[modify] https://crrev.com/8a1133a0a03490e165640af6bc9dfd5d070c06ce/components/omnibox/browser/omnibox_view.cc

Sign in to add a comment