New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 906176 link

Starred by 0 users
Status: Verified
Owner:
gambard@chromium.org
Closed: Nov 19
Cc:
stkhapugin@chromium.org
justincohen@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Toolbar in NewTabPage is also scrolling in landscape mode.

Project Member Reported by srikan...@google.com, Nov 16 
App Version: 72.0.3612.0 canary
iOS Version: 12.1, 11.4.1
Device: iPhone6s, iPhoneX
URL: NA

Steps to reproduce:
  1. Launch Google Chrome in Landscape mode
  2. Scroll down the new tab page

Observed results: Observe that the toolbar is also scrolling slightly 

Expected results: Toolbar shouldn't be scrolling. It should be fixed at the top of the screen.

Number of times you were able to reproduce: 5/5
Bug reproducible after clean install: Yes
Bug reproducible after clearing cache and cookies: Yes
Bug reproducible on Chrome Mobile on Android: 
Bug reproducible on Safari/Firefox: Firefox: NA, Safari: NA
Bug reproducible on current stable build (App Version, iOS Version): M70 NO
Bug reproducible on the current beta channel build (App Version, iOS Version): M71 NO
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a289922bbc39f8d70ac7abb580b300f2e330ad1c

commit a289922bbc39f8d70ac7abb580b300f2e330ad1c
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Nov 19 17:15:20 2018

[iOS] Change the NTP animation of the location bar

This CL changes the way to NTP is animating the appearance of the
location bar in the toolbar when the device has a regular width.
It uses a transform instead of changing the bottom constraint of the
location bar.

Bug:  906176 
Change-Id: Ia110cafd9d2093a82487b2e3c342337c8cf7ef12
Reviewed-on: https://chromium-review.googlesource.com/c/1341911
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609340}
[modify] https://crrev.com/a289922bbc39f8d70ac7abb580b300f2e330ad1c/ios/chrome/browser/ui/toolbar/primary_toolbar_view_controller.mm

Comment 2 by gambard@chromium.org, Nov 19

Status: Fixed (was: Assigned)

Comment 3 by rakurati@chromium.org, Nov 27

Status: Verified (was: Fixed)
Verified in 72.0.3622.0 Canary in iPhone 8plus(iOS 12.1.1 beta#3), iPhone 8(iOS 11.4.1) and iPhone SE(iOS 12.0.1)

Toolbar in NewTabPage is not scrolling any more in landscape mode, looks good.

Link to video:
https://drive.google.com/file/d/1AaXtV0lhK0CnUYMDcwPbklmZbeOKEsJp/view?usp=sharing
►

Sign in to add a comment