New issue
Advanced search Search tips

Issue 906167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 21
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

printer.AddGenericPrinter always failing due to read request mismatch

Project Member Reported by derat@chromium.org, Nov 16

Issue description

printer.AddGenericPrinter is failing consistently on release builders. For example, from http://stainless/browse/chromeos-autotest-results/257536598-chromeos-test/ :

2018/11/15 09:11:22 Started test printer.AddGenericPrinter
2018/11/15 09:11:22 [09:11:21.880] Waiting for org.chromium.debugd D-Bus service
2018/11/15 09:11:22 [09:11:21.880] Registering a printer
2018/11/15 09:11:22 [09:11:22.048] Issuing print request
2018/11/15 09:11:22 [09:11:22.091] Receiving print request
2018/11/15 09:11:26 [09:11:26.122] Error at add_generic_printer.go:100: Read request has diff from the golden file, dumped at printer_add_generic_printer_diff.txt
2018/11/15 09:11:26 [09:11:26.122] Stack trace:
Read request has diff from the golden file, dumped at printer_add_generic_printer_diff.txt
	at chromiumos/tast/local/bundles/cros/printer.AddGenericPrinter (add_generic_printer.go:100)
	at chromiumos/tast/testing.(*Test).Run.func4 (test.go:189)
	at chromiumos/tast/testing.runStages.func1.1 (stage.go:39)
	at chromiumos/tast/testing.runAndRecover.func1 (stage.go:69)
	at runtime.goexit (asm_amd64.s:2361)
2018/11/15 09:11:27 Completed test printer.AddGenericPrinter in 4.784s with 1 error(s)

Here's the diff:

@@ -4,8 +4,8 @@
 %%LanguageLevel: 3
 %%DocumentSuppliedResources: (atend)
 %%DocumentMedia: Letter 612 792 0 () ()
-%%For: (anonymous)
-%%Title: (Untitled)
+%%For: (root)
+%%Title: (to_print.pdf)
 %RBINumCopies: 1
 %%Pages: (atend)
 %%BoundingBox: (atend)
 
Cups was updated recently. I updated the autotest. I didn't know we had a
tast test. I can update on Monday.

On Fri, Nov 16, 2018, 11:18 derat via monorail <
monorail+v2.806931980@chromium.org wrote:
Thanks!
Cc: hidehiko@chromium.org
Owner: skau@chromium.org
Re #1: Thank you, skau@. Let me assign this to you.

Status: Started (was: Untriaged)
Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3a0e1cda3b9975a2f137af197dad358c41f3f108

commit 3a0e1cda3b9975a2f137af197dad358c41f3f108
Author: Sean Kau <skau@chromium.org>
Date: Wed Nov 21 13:53:01 2018

printing.AddGenericPrinter: Update golden file

Generated PostScript changed when CUPS was updated.  Fix accordingly.

TEST=tast run ... printing.AddGenericPrinter
BUG= chromium:906167 

Change-Id: I3541f70b6895dcfbf95ba4bf54c8d981feed21f9
Reviewed-on: https://chromium-review.googlesource.com/1344656
Commit-Ready: Sean Kau <skau@chromium.org>
Tested-by: Sean Kau <skau@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/3a0e1cda3b9975a2f137af197dad358c41f3f108/chromeos-base/tast-local-tests-cros/tast-local-tests-cros-9999.ebuild
[modify] https://crrev.com/3a0e1cda3b9975a2f137af197dad358c41f3f108/chromeos-base/tast-local-tests-cros/Manifest
[modify] https://crrev.com/3a0e1cda3b9975a2f137af197dad358c41f3f108/chromeos-base/tast-local-tests-cros/files/external_data.conf

Status: Fixed (was: Started)

Sign in to add a comment