Issue metadata
Sign in to add a comment
|
Refactor CrosFpBiometricsManager to facilitate code re-use in bio_crypto_init |
||||||||||||||||||||||||
Issue descriptionRe-organize some of the CrosFpBiometricsManager code to avoid code duplication in bio_crypto_init. Also, possibly break the CrosFpDevice code into a separate file.
,
Nov 28
,
Dec 8
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/b020e79d51c22bef7a4185b9d85b6cfc609b05c2 commit b020e79d51c22bef7a4185b9d85b6cfc609b05c2 Author: Prashant Malani <pmalani@chromium.org> Date: Sat Dec 08 02:09:19 2018 biod: Refactor CrosFpDevice to re-use function in bio_crypto_init This CL refactors some of CrosFpDevice, including moving the class declarations inside the CrosFpBiometricsManager header, so that we can re-use the WaitOnEcBoot() routine, instead of copying it into bio_crypto_init. The next step is to break out CrosFpDevice into it's own file and header, but this CL can be a less-disruptive first step. BUG=b:117909326, chromium:906164 TEST=Build and boot, verify that enrollment and unlock works as expected. Change-Id: I9ec3042be6f350822e01feebd40d9c57ae8a8417 Reviewed-on: https://chromium-review.googlesource.com/1338210 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Prashant Malani <pmalani@google.com> Reviewed-by: Nicolas Norvez <norvez@chromium.org> (cherry picked from commit 399545f2d1443de0355026b6ba6e65a2ed07fda3) Reviewed-on: https://chromium-review.googlesource.com/c/1362365 Reviewed-by: YH Lin <yueherngl@chromium.org> Commit-Queue: YH Lin <yueherngl@chromium.org> Tested-by: YH Lin <yueherngl@chromium.org> [modify] https://crrev.com/b020e79d51c22bef7a4185b9d85b6cfc609b05c2/biod/cros_fp_biometrics_manager.cc [modify] https://crrev.com/b020e79d51c22bef7a4185b9d85b6cfc609b05c2/biod/cros_fp_biometrics_manager.h [modify] https://crrev.com/b020e79d51c22bef7a4185b9d85b6cfc609b05c2/biod/bio_crypto_init.cc |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Nov 27