New issue
Advanced search Search tips

Issue 906154 link

Starred by 1 user
Status: Fixed
Owner:
pdr@chromium.org
Closed: Nov 20
Cc:
vmp...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 836886



Sign in to add a comment

[BlinkGenPropertyTrees] Css clip with filter and opacity hits a DCHECK

Project Member Reported by pdr@chromium.org, Nov 16 
The following testcase crashes:
<!doctype html>
<style>
.icon {
  position: absolute;
  width: 100px;
  height: 100px;
  background: lightgreen;
  will-change: opacity;
  filter: blur(1px);
  clip: rect(10px, 10px, 10px, 10px);
}
</style>
<div class="icon"></div>

FATAL:property_tree_manager.cc(578)] Check failed: IsCurrentCcEffectSynthetic().
crasher.html
231 bytes View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/396a0004389678677bdf37c2ad683b56afdf216e

commit 396a0004389678677bdf37c2ad683b56afdf216e
Author: Philip Rogers <pdr@chromium.org>
Date: Tue Nov 20 23:28:52 2018

[BlinkGenPropertyTrees] Filter effects should be clipped

According to the spec, filtering should apply before clipping
(https://drafts.fxtf.org/css-masking-1/#placement): "...effects are applied to
the element in order: filter effects, clipping, masking and opacity."

This patch fixes clip-path order with BlinkGenPropertyTrees (BGPT) which exposed
the issue of filter and clip order. Testcases have been added showing the fixed
behavior with BGPT, and the non-BGPT results have been marked as failing.

NOTRY=true

Bug:  906154 ,  907175 
Change-Id: I5e9c7dbb7c694afc623fbc3bb2c7f2f8cc458195
Reviewed-on: https://chromium-review.googlesource.com/c/1344217
Commit-Queue: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609847}
[modify] https://crrev.com/396a0004389678677bdf37c2ad683b56afdf216e/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-gen-property-trees
[modify] https://crrev.com/396a0004389678677bdf37c2ad683b56afdf216e/third_party/WebKit/LayoutTests/TestExpectations
[add] https://crrev.com/396a0004389678677bdf37c2ad683b56afdf216e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-filter-order-ref.html
[add] https://crrev.com/396a0004389678677bdf37c2ad683b56afdf216e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip-path/clip-path-filter-order.html
[add] https://crrev.com/396a0004389678677bdf37c2ad683b56afdf216e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip/clip-filter-order-ref.html
[add] https://crrev.com/396a0004389678677bdf37c2ad683b56afdf216e/third_party/WebKit/LayoutTests/external/wpt/css/css-masking/clip/clip-filter-order.html
[add] https://crrev.com/396a0004389678677bdf37c2ad683b56afdf216e/third_party/WebKit/LayoutTests/external/wpt/svg/rendering/order/clip-path-filter-order-ref.svg
[add] https://crrev.com/396a0004389678677bdf37c2ad683b56afdf216e/third_party/WebKit/LayoutTests/external/wpt/svg/rendering/order/clip-path-filter-order.svg
[modify] https://crrev.com/396a0004389678677bdf37c2ad683b56afdf216e/third_party/blink/renderer/core/paint/compositing/compositing_layer_property_updater.cc

Comment 2 by pdr@chromium.org, Nov 20

Status: Fixed (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d8a865f2603afc63e8bfa957bb8d17009bd005f1

commit d8a865f2603afc63e8bfa957bb8d17009bd005f1
Author: Philip Rogers <pdr@chromium.org>
Date: Wed Dec 05 17:05:22 2018

[BlinkGenPropertyTrees] Mark http/tests/devtools/profiler/ as passing

This patch removes passing tests under http/tests/devtools/profiler/
from the BlinkGenPropertyTrees expectations.

Bug:  906154 
Change-Id: Ic7daa099c60118084e7789eb14d71cb446500c75
Reviewed-on: https://chromium-review.googlesource.com/c/1363362
Commit-Queue: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#613998}
[modify] https://crrev.com/d8a865f2603afc63e8bfa957bb8d17009bd005f1/third_party/blink/web_tests/FlagExpectations/enable-blink-features=BlinkGenPropertyTrees
►

Sign in to add a comment