Issue 906151 link

Starred by 1 user

Issue metadata

Status:	Started
Owner:	dewittj@chromium.org
Cc:	█ chili@chromium.org █ ramyan@chromium.org
Components:	UI>Browser>NewTabPage>ExploreSites
EstimatedDays:	----
NextAction:	----
OS:	Android
Pri:	1
Type:	Bug

Fix render tests for Explore Sites

Project Member Reported by dewittj@chromium.org, Nov 16

Issue description

We need ExploreSites running on the perf bots, but the render tests are failing because we changed the NTP UI.  We will achieve this in multiple steps:

* Enable the feature on the perf bots and disable the feature in the failing Render Tests: NewTabPageTest and TileGridLayoutTest.
* Fix the failing tests and parameterize as necessary, uploading goldens and enabling them.

Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/549bcac9e03c43ec783470b3715ca6a7a4ba8f29

commit 549bcac9e03c43ec783470b3715ca6a7a4ba8f29
Author: Justin DeWitt <dewittj@chromium.org>
Date: Fri Nov 16 23:11:20 2018

[EoS] Add a fieldtrial config before launching to beta/stable.

Bug:  904986 , 906151
Change-Id: I5aef21b730446234742c2420435aeba8fb81f76e
Reviewed-on: https://chromium-review.googlesource.com/c/1334274
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609016}
[modify] https://crrev.com/549bcac9e03c43ec783470b3715ca6a7a4ba8f29/chrome/android/javatests/src/org/chromium/chrome/browser/ntp/NewTabPageTest.java
[modify] https://crrev.com/549bcac9e03c43ec783470b3715ca6a7a4ba8f29/chrome/android/javatests/src/org/chromium/chrome/browser/suggestions/TileGridLayoutTest.java
[modify] https://crrev.com/549bcac9e03c43ec783470b3715ca6a7a4ba8f29/testing/variations/fieldtrial_testing_config.json

►

Issue 906151 link

Issue metadata

Fix render tests for Explore Sites

Issue description

Comment 1 by bugdroid1@chromium.org, Nov 16

Comment 1 Deleted

Sign in to add a comment