New issue
Advanced search Search tips

Issue 906135 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 3
Type: Bug


Show other hotlists

Hotlists containing this issue:
Autofill-Fixit


Sign in to add a comment

[Autofill] Delete unused chrome://flags entries

Project Member Reported by ma...@chromium.org, Nov 16

Issue description

Plenty of unused flags entries for Autofill. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b94510df5ea273ea074370c6437bdc5c5535e89

commit 1b94510df5ea273ea074370c6437bdc5c5535e89
Author: Mathieu Perreault <mathp@chromium.org>
Date: Fri Nov 16 18:29:57 2018

[Autofill flags] Adding owners to the autofill-related flags.

Bug: 906135

Change-Id: Ibdf7195d93a8dc340e6ce9cdd3ab11b4917bdd1e
Reviewed-on: https://chromium-review.googlesource.com/c/1340659
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608861}
[modify] https://crrev.com/1b94510df5ea273ea074370c6437bdc5c5535e89/chrome/browser/flag-metadata.json

Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93ab706da57c8c93c90eff816b6830d17b8227b4

commit 93ab706da57c8c93c90eff816b6830d17b8227b4
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu Dec 20 16:10:36 2018

[Autofill] Delete some Features related to Rationalization

The code has been enabled by default for a while.

Bug: 906135
Change-Id: I42416b8427137769ebeab4647e8679bab7665fe2
Reviewed-on: https://chromium-review.googlesource.com/c/1386649
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618229}
[modify] https://crrev.com/93ab706da57c8c93c90eff816b6830d17b8227b4/chrome/browser/about_flags.cc
[modify] https://crrev.com/93ab706da57c8c93c90eff816b6830d17b8227b4/components/autofill/core/browser/autofill_manager.cc
[modify] https://crrev.com/93ab706da57c8c93c90eff816b6830d17b8227b4/components/autofill/core/browser/autofill_manager_unittest.cc
[modify] https://crrev.com/93ab706da57c8c93c90eff816b6830d17b8227b4/components/autofill/core/browser/form_structure.cc
[modify] https://crrev.com/93ab706da57c8c93c90eff816b6830d17b8227b4/components/autofill/core/browser/form_structure_unittest.cc
[modify] https://crrev.com/93ab706da57c8c93c90eff816b6830d17b8227b4/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/93ab706da57c8c93c90eff816b6830d17b8227b4/components/autofill/core/common/autofill_features.h

Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c6dd1fda26ff8dddd92ba7830e8696afe3b031f5

commit c6dd1fda26ff8dddd92ba7830e8696afe3b031f5
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu Dec 20 19:28:57 2018

[Autofill] Removing unused flags descriptions.

Forgot to remove descriptions as part of a previous change.
Also removing unused fieldtrial configs.

TBR=rkaplow

Bug: 906135
Change-Id: I3a3bc1c732347e2d0e951df1f36d406e817f9b20
Reviewed-on: https://chromium-review.googlesource.com/c/1387404
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618288}
[modify] https://crrev.com/c6dd1fda26ff8dddd92ba7830e8696afe3b031f5/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/c6dd1fda26ff8dddd92ba7830e8696afe3b031f5/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/c6dd1fda26ff8dddd92ba7830e8696afe3b031f5/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/680ffca4684a7bf30e6440d3f3d8e330eb7f580a

commit 680ffca4684a7bf30e6440d3f3d8e330eb7f580a
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu Dec 20 19:54:28 2018

[Autofill] Clean upstream Google Pay branding feature

Has been enabled for a while.

TBR=rkaplow

Bug: 906135
Change-Id: I1efecc7710d16711de48ac0e0f094f284cda629e
Reviewed-on: https://chromium-review.googlesource.com/c/1387047
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618292}
[modify] https://crrev.com/680ffca4684a7bf30e6440d3f3d8e330eb7f580a/chrome/browser/about_flags.cc
[modify] https://crrev.com/680ffca4684a7bf30e6440d3f3d8e330eb7f580a/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/680ffca4684a7bf30e6440d3f3d8e330eb7f580a/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/680ffca4684a7bf30e6440d3f3d8e330eb7f580a/components/autofill/core/browser/autofill_save_card_infobar_delegate_mobile.cc
[modify] https://crrev.com/680ffca4684a7bf30e6440d3f3d8e330eb7f580a/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/680ffca4684a7bf30e6440d3f3d8e330eb7f580a/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/680ffca4684a7bf30e6440d3f3d8e330eb7f580a/ios/chrome/browser/ios_chrome_flag_descriptions.cc
[modify] https://crrev.com/680ffca4684a7bf30e6440d3f3d8e330eb7f580a/ios/chrome/browser/ios_chrome_flag_descriptions.h
[modify] https://crrev.com/680ffca4684a7bf30e6440d3f3d8e330eb7f580a/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 5 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74

commit 6757b704a768fb4f7ba9a9637cd7e5be0ac35a74
Author: Mathieu Perreault <mathp@chromium.org>
Date: Thu Dec 20 21:33:00 2018

[Autofill] Remove SingleClick feature entry.

Feature has been on by default for a while.

TBR=rkaplow

Bug: 906135
Change-Id: Ib44fe4d5cc728c622d33b2e4a9eeb5c0415b6aae
Reviewed-on: https://chromium-review.googlesource.com/c/1387153
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618329}
[modify] https://crrev.com/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74/chrome/browser/about_flags.cc
[modify] https://crrev.com/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74/chrome/browser/autofill/autofill_interactive_uitest.cc
[modify] https://crrev.com/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74/chrome/browser/autofill/autofill_provider_browsertest.cc
[modify] https://crrev.com/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74/components/autofill/content/renderer/autofill_agent.cc
[modify] https://crrev.com/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/6757b704a768fb4f7ba9a9637cd7e5be0ac35a74/testing/variations/fieldtrial_testing_config.json

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f2d26633cbd50735ac2af30436888b71ac0abad3

commit f2d26633cbd50735ac2af30436888b71ac0abad3
Author: Mathieu Perreault <mathp@chromium.org>
Date: Wed Jan 09 23:11:26 2019

[Autofill] Remove AutofillPopupViewViews and associated feature.

Bug: 906135,831603
Change-Id: I3c982f8b3ffb4928c7c878e74e10113999106499
Reviewed-on: https://chromium-review.googlesource.com/c/1387124
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Tommy Martino <tmartino@chromium.org>
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621360}
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/chrome/browser/about_flags.cc
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/chrome/browser/ui/autofill/autofill_popup_controller_interactive_uitest.cc
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/chrome/browser/ui/views/autofill/autofill_popup_base_view.cc
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/chrome/browser/ui/views/autofill/autofill_popup_base_view.h
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.cc
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/chrome/browser/ui/views/autofill/autofill_popup_view_native_views.h
[delete] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/ui/views/autofill/autofill_popup_view_views.cc
[delete] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/ui/views/autofill/autofill_popup_view_views.h
[delete] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/ui/views/autofill/autofill_popup_view_views_browsertest.cc
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/chrome/test/BUILD.gn
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/components/autofill/core/browser/autofill_external_delegate.cc
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/components/autofill/core/browser/autofill_external_delegate_unittest.cc
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/components/autofill/core/common/autofill_features.cc
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/components/autofill/core/common/autofill_features.h
[modify] https://crrev.com/f2d26633cbd50735ac2af30436888b71ac0abad3/testing/variations/fieldtrial_testing_config.json

Sign in to add a comment