New issue
Advanced search Search tips

Issue 906115 link

Starred by 1 user
Status: Fixed
Owner:
smcgruer@chromium.org
Closed: Nov 16
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

ScrollTimeline - writing-mode/directionality broken on composited ScrollTimeline

Project Member Reported by smcgruer@chromium.org, Nov 16 
Currently writing-mode and directionality are not represented on the compositor. We end up just translating to Horizontal or Vertical and treating the scroller like it always has an origin of (0, 0), rather than flipping the axes when necessary.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4423736605e8c1008d5151e0fe6251845a7d1229

commit 4423736605e8c1008d5151e0fe6251845a7d1229
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Fri Nov 16 22:21:38 2018

Fix compositor ScrollTimeline handling of writing-modes

Previously we would get writing-modes/directionality completely
wrong for composited ScrollTimelines. This CL teaches cc::ScrollTimeline
about 'reverse' axes, without exposing the concepts of writing-mode or
directionality to it.

Bug:  906115 
Change-Id: Id843668956b0766469148c1ae6ad33fca582ba63
Reviewed-on: https://chromium-review.googlesource.com/c/1310567
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608987}
[modify] https://crrev.com/4423736605e8c1008d5151e0fe6251845a7d1229/cc/animation/animation_host_unittest.cc
[modify] https://crrev.com/4423736605e8c1008d5151e0fe6251845a7d1229/cc/animation/scroll_timeline.cc
[modify] https://crrev.com/4423736605e8c1008d5151e0fe6251845a7d1229/cc/animation/scroll_timeline.h
[modify] https://crrev.com/4423736605e8c1008d5151e0fe6251845a7d1229/cc/animation/scroll_timeline_unittest.cc
[modify] https://crrev.com/4423736605e8c1008d5151e0fe6251845a7d1229/cc/animation/worklet_animation_unittest.cc
[modify] https://crrev.com/4423736605e8c1008d5151e0fe6251845a7d1229/third_party/WebKit/LayoutTests/animations/animationworklet/resources/animation-worklet-tests.js
[add] https://crrev.com/4423736605e8c1008d5151e0fe6251845a7d1229/third_party/WebKit/LayoutTests/animations/animationworklet/scroll-timeline-writing-modes.html
[modify] https://crrev.com/4423736605e8c1008d5151e0fe6251845a7d1229/third_party/blink/renderer/modules/animationworklet/worklet_animation.cc

Comment 2 by smcgruer@chromium.org, Nov 16

Status: Fixed (was: Started)
►

Sign in to add a comment