Move function IsUsernameAllowedByPattern to //components/signin/core/browser:shared |
||||
Issue descriptionAdd a new file, move the function there, and fix compilation. Also need to add unit tests if they don't exists (look in SigninManager unit tests suite). If they exists, they should be moved out of SigninManager and into the tests for //components/signin/core/browser:shared target (needs to be created if it does not exists).
,
Nov 16
,
Nov 19
,
Nov 21
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77fd4f6bdd5efe6ae26a37290d71631f5aec0fc3 commit 77fd4f6bdd5efe6ae26a37290d71631f5aec0fc3 Author: Mario Sanchez Prada <mario@igalia.com> Date: Wed Nov 21 15:35:10 2018 Move IsUsernameAllowedByPattern to //components/signin/core/browser:shared Move this utility method's declaration & definition to identity_utils.[h|cc] and provide a specific test suite to check its functionality, in preparation for the future removal of the SigninManager class and its relocation to the Identity service. Bug: 906084 Change-Id: Ie3fd26501ea95266d35d6e3640935a8e07b45afa Reviewed-on: https://chromium-review.googlesource.com/c/1346093 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#610067} [modify] https://crrev.com/77fd4f6bdd5efe6ae26a37290d71631f5aec0fc3/components/signin/core/browser/BUILD.gn [add] https://crrev.com/77fd4f6bdd5efe6ae26a37290d71631f5aec0fc3/components/signin/core/browser/identity_utils.cc [add] https://crrev.com/77fd4f6bdd5efe6ae26a37290d71631f5aec0fc3/components/signin/core/browser/identity_utils.h [add] https://crrev.com/77fd4f6bdd5efe6ae26a37290d71631f5aec0fc3/components/signin/core/browser/identity_utils_unittest.cc [modify] https://crrev.com/77fd4f6bdd5efe6ae26a37290d71631f5aec0fc3/components/signin/core/browser/signin_manager.cc [modify] https://crrev.com/77fd4f6bdd5efe6ae26a37290d71631f5aec0fc3/components/signin/core/browser/signin_manager.h
,
Nov 21
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sdefresne@chromium.org
, Nov 16