Extract SigninManager::IsUsernameAllowedByPolicy to a free function |
|||||
Issue descriptionTo allow removing dependency on SigninManager::IsUsernameAllowedByPolicy, the method needs to be extracted to a free function.
,
Nov 16
,
Nov 16
,
Nov 19
,
Nov 20
,
Nov 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa2d589a44a2ba457694af71e3120b7133a68f73 commit fa2d589a44a2ba457694af71e3120b7133a68f73 Author: Mario Sanchez Prada <mario@igalia.com> Date: Wed Nov 21 11:22:14 2018 Extract SigninManager::IsUsernameAllowedByPolicy to a free function This is the first step of those that will allow us remove the dependency from SigninManager::IsAllowedUsername() in the long run, as part of our effort to migrate parts of the code base to the Identity service. Note that this free function will be in the |identity| namespace even if it's actually declared & defined in signin_manager.[h|cc] for now, which should be ok since this is just a temporary situation until we get to a state where SigninManager is not used by any consumers outside //services/identity, at which point we'd simply move it to the public C++ API in there. We can't do it now, though, because doing so would create a dependency cycle as //components/signin would have to depend on //services/identity (which in turn depends on //components/signin). Bug: 906081 Change-Id: I0ec5817661c0cfd27c7a08ef67eae389beff1230 Reviewed-on: https://chromium-review.googlesource.com/c/1344145 Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#609998} [modify] https://crrev.com/fa2d589a44a2ba457694af71e3120b7133a68f73/components/signin/core/browser/signin_manager.cc [modify] https://crrev.com/fa2d589a44a2ba457694af71e3120b7133a68f73/components/signin/core/browser/signin_manager.h
,
Nov 21
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by sdefresne@chromium.org
, Nov 16This free function should probably have the following prototype: namespace identity { bool IsUsernameAllowedByPattern( base::StringPiece username, base::StringPiece pattern); }