Write implementation and tests for PrimaryAccountMutatorImpl::LegacyCopyCredentialsFrom |
|||
Issue descriptionThe method should cast the passed reference to PrimaryAccountMutatorImpl to access the SigninManager of the source and can then delegate to SigninManager::CopyCredentialsFrom. The tests can be based on the tests of the method of SigninManager.
,
Dec 20
Taking this one
,
Dec 20
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/666b68ef7d8caecbb326de42d2127b34bf5354ed commit 666b68ef7d8caecbb326de42d2127b34bf5354ed Author: Mario Sanchez Prada <mario@igalia.com> Date: Thu Dec 20 17:10:06 2018 Implement PrimaryAccountMutatorImpl::LegacyCopyCredentialsFrom() Add implementation and a new unit test for this legacy API. Bug: 906065 Change-Id: Iac276d876e2c3b44d2fe8d99c1218a9c9e72ecd3 Reviewed-on: https://chromium-review.googlesource.com/c/1386549 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#618249} [modify] https://crrev.com/666b68ef7d8caecbb326de42d2127b34bf5354ed/services/identity/public/cpp/primary_account_mutator_impl.cc [modify] https://crrev.com/666b68ef7d8caecbb326de42d2127b34bf5354ed/services/identity/public/cpp/primary_account_mutator_unittest.cc
,
Dec 20
|
|||
►
Sign in to add a comment |
|||
Comment 1 by toniki...@chromium.org
, Dec 17