Issue metadata
Sign in to add a comment
|
"CHOOSE TRYJOBS" does not show up occasionally in the buildbucket plugin |
||||||||||||||||||||||||
Issue descriptionOn the first page load, maybe 50% of the time, the link does not show up (or it shows up and then disappears), but if we refresh the page the link shows up consistently. We have been noticing this for a while now. I think we can reproduce it fairly reliably on changes where no tryjobs have been run yet. Eg: https://skia-review.googlesource.com/c/buildbot/+/150929 also for chromium-review- https://chromium-review.googlesource.com/c/chromium/src/+/1054515 Hopefully the above changes helps us reproduce this. Let me know if it does not.
,
Nov 21
the "displayed -> disappears" flaky transition is being fixed by https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1347297/ it does not solve the underlying problem i cannot reliably reproduce this, but the display bit is controlled by https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/f35cbd7/src/main/resources/static/cr-buildbucket-view.js#298 loggedIn param there is the most flaky one. I've discovered an auth-related bug that might fix this problem. https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1347297 Let's land both changes and revisit.
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/6b672fa663667481ee2fd3c186ebe37eefec430a commit 6b672fa663667481ee2fd3c186ebe37eefec430a Author: Nodir Turakulov <nodir@google.com> Date: Thu Nov 22 00:05:06 2018 [buildbucket] Hide "CHOOSE TRYBOTS" button by default Currently the "CHOOSE TRYBOTS" button is displayed until an actual value of $hidden is computed. If it turns out to be hidden, the button disappears. This is confusing. Hide the button by default by binding $hidden to a property which is false by default, and always defined. Bug: 906057 Change-Id: I016c5ea7bb1ec38a82b3063d91b866fa7892fbca Reviewed-on: https://chromium-review.googlesource.com/c/1347297 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/6b672fa663667481ee2fd3c186ebe37eefec430a/src/main/resources/static/cr-buildbucket-view.html [modify] https://crrev.com/6b672fa663667481ee2fd3c186ebe37eefec430a/src/main/resources/static/cr-buildbucket-view.js
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/0aad4bda48aed1764e1895b3a1f7f55a541d6196 commit 0aad4bda48aed1764e1895b3a1f7f55a541d6196 Author: Nodir Turakulov <nodir@google.com> Date: Thu Nov 22 00:16:50 2018 [buildbucket] Handle concurrent _configureOAuthLibrary calls. In practice, multiple ~concurrent client._configureOAuthLibrary() are made before the first one resolved. Add _sharedAuthState.loading to handle this case. Bug: 906057 Change-Id: I264c6d0f375aef1d62e5f64aab7d9aab37afd9b0 Reviewed-on: https://chromium-review.googlesource.com/c/1347295 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> [modify] https://crrev.com/0aad4bda48aed1764e1895b3a1f7f55a541d6196/src/main/resources/static/cr-buildbucket-client.js [modify] https://crrev.com/0aad4bda48aed1764e1895b3a1f7f55a541d6196/test/cr-buildbucket-client_test.html
,
Nov 27
The NextAction date has arrived: 2018-11-27
,
Nov 28
,
Nov 28
,
Nov 28
,
Nov 30
The NextAction date has arrived: 2018-11-30
,
Dec 4
update: rewriting auth layer https://chromium-review.googlesource.com/c/infra/gerrit-plugins/buildbucket/+/1356850
,
Dec 7
The following revision refers to this bug: https://chromium.googlesource.com/infra/gerrit-plugins/buildbucket/+/cf5f9e646a20730ac90af855353d713311ec2e2e commit cf5f9e646a20730ac90af855353d713311ec2e2e Author: Nodir Turakulov <nodir@google.com> Date: Fri Dec 07 04:48:05 2018 [buildbucket] Rewrite auth code The current implementation of auth stack in buildbucket plugin is the primary source of problems in the plugin. In particular, it is highly flaky. Rewrite it and move it out to a separate plain old JS class, as opposed to a Polymer element. Use global "buildbucket" variable for sharing JS symbols. Bug: 906057 , gerrit:9164 Change-Id: If73ffc7f5973d99d6a1894927b2925a04df0db91 Reviewed-on: https://chromium-review.googlesource.com/c/1356850 Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> [add] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/src/main/resources/static/auth.js [modify] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/src/main/resources/static/buildbucket.html [add] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/test/test-util.js [modify] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/src/main/resources/static/cr-tryjob-picker.js [modify] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/test/cr-buildbucket-view_test.html [modify] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/src/main/resources/static/cr-buildbucket-client.js [modify] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/test/cr-tryjob-picker_test.html [modify] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/src/main/resources/static/cr-buildbucket-view.html [add] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/test/auth_test.html [modify] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/test/cr-buildbucket-client_test.html [add] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/src/main/resources/static/promises.js [modify] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/test/index.html [modify] https://crrev.com/cf5f9e646a20730ac90af855353d713311ec2e2e/src/main/resources/static/cr-buildbucket-view.js
,
Jan 3
deployment started. It will take a few days.
,
Jan 7
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 Deleted