New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 906034 link

Starred by 1 user
Status: Assigned
Owner:
treib@chromium.org
Cc:
mastiz@chromium.org
msramek@chromium.org
treib@chromium.org
ios-bugs@chromium.org
█ tschumann@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

Sync: "preferred" or "chosen" data types should be empty by default

Project Member Reported by treib@chromium.org, Nov 16 
Currently, SyncUserSettings::GetChosenDataTypes() and SyncService::GetPreferredDataTypes() both return "all types" by default, even if the user has never enabled Sync, or if only Sync-the-transport is running. That is misleading and can easily cause privacy-relevant bugs. We should check if it's feasible to return "no types" if Sync isn't actually enabled.
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/50069dbe55400d8d53c5730671ff42c2db0d8a7a

commit 50069dbe55400d8d53c5730671ff42c2db0d8a7a
Author: Marc Treib <treib@chromium.org>
Date: Mon Nov 19 15:04:39 2018

Improve comments on SyncUserSettings

Some of the settings have surprising default values. As a first step,
let's at least document those.

Bug: 884159, 906034
Change-Id: I8ee8ba2d6ffc2886f8bc623062787d6ec8d332ed
Reviewed-on: https://chromium-review.googlesource.com/c/1340301
Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609291}
[modify] https://crrev.com/50069dbe55400d8d53c5730671ff42c2db0d8a7a/components/sync/driver/sync_user_settings.h

Comment 2 by mastiz@chromium.org, Jan 15

Labels: Sync-Triaged
Owner: treib@chromium.org
Status: Assigned (was: Available)
Assigning to treib@ who reported this and has also worked in related patches like the one above and also https://chromium-review.googlesource.com/c/chromium/src/+/1402877, which is somewhat related.
►

Sign in to add a comment