New issue
Advanced search Search tips

Issue 906020 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 5
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocked on:
issue 904404

Blocking:
issue 883318



Sign in to add a comment

Port user_image_manager_browsertest.cc away from ProfileOAuth2TokenService

Project Member Reported by blundell@chromium.org, Nov 16

Issue description

It should use identity_test_utils instead.
 
Owner: svil...@igalia.com
Status: Started (was: Available)
Checking this..
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2fdbdbfe1546353136a7f8ce765326cb2d0388c4

commit 2fdbdbfe1546353136a7f8ce765326cb2d0388c4
Author: Sergio Villar Senin <svillar@igalia.com>
Date: Wed Dec 05 09:34:01 2018

Port user_image_manager_browsertest.cc away from ProfileOAuth2TokenService

Replaced the ProfileOAuth2TokenService API by the identity API.

A new function was added to the identity test utils which returns the
refresh token set for a given account whenever SetRefreshTokenForAccount()
is called.

Bug:  906020 
Change-Id: If296ecd02d955ca34d08114e7ea420d33d6bb465
Reviewed-on: https://chromium-review.googlesource.com/c/1349983
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Sergio Villar <svillar@igalia.com>
Cr-Commit-Position: refs/heads/master@{#613919}
[modify] https://crrev.com/2fdbdbfe1546353136a7f8ce765326cb2d0388c4/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc
[modify] https://crrev.com/2fdbdbfe1546353136a7f8ce765326cb2d0388c4/services/identity/public/cpp/identity_manager.h
[modify] https://crrev.com/2fdbdbfe1546353136a7f8ce765326cb2d0388c4/services/identity/public/cpp/identity_test_utils.cc
[modify] https://crrev.com/2fdbdbfe1546353136a7f8ce765326cb2d0388c4/services/identity/public/cpp/identity_test_utils.h

Status: Fixed (was: Started)
Fixed!

Sign in to add a comment