Issue metadata
Sign in to add a comment
|
Regression : Unnecessarily Tab focus is seen on disabled 'Color temperature' slider in chrome://settings/display |
||||||||||||||||||||||
Issue descriptionChrome Version: 72.0.3609.3/11264.0.0 dev-channel Kip,Reks and Daisy OS: Chrome What steps will reproduce the problem? (1)Sign into User ->Go to chrome://settings/display ->Now press 'Tab' until focus is on 'Night Light' toggle option and again press 'Tab' (2)Observe unnecessarily Tab focus is seen on 'Color temperature' slider which is disabled and on clicking any button at Keyboard nothing happens(it will be enabled only after enabling 'Night Light' toggle option ) (Please refer Video and Screenshot) Expected: Unnecessarily Tab focus should not be seen on 'Color temperature' slider Actual: instead unnecessarily Tab focus is seen on 'Color temperature' slider This is Regression Issue as same is working fine on M-69 Note : Issue is also seen on M-71
,
Nov 16
Could this be a duplicate of https://bugs.chromium.org/p/chromium/issues/detail?id=905999 ?
,
Nov 16
dpapad@, thanks for explaining the other focus issue. After looking at the code, I think this issue is different from 905999. It looks like I completely missed updating the tabindex when the control is disabled. https://chromium-review.googlesource.com/c/chromium/src/+/1341059
,
Nov 17
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/699a981613c6e2bc5367f0d0bdcc55fc599f746e commit 699a981613c6e2bc5367f0d0bdcc55fc599f746e Author: Esmael El-Moslimany <aee@chromium.org> Date: Sat Nov 17 01:20:41 2018 WebUI: cr-slider, make knob not focusable when disabled Bug: 906009 Change-Id: Ic3ad0336522415492c043bc125ced0fa5796f169 Reviewed-on: https://chromium-review.googlesource.com/c/1341059 Reviewed-by: Scott Chen <scottchen@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#609061} [modify] https://crrev.com/699a981613c6e2bc5367f0d0bdcc55fc599f746e/ui/webui/resources/cr_elements/cr_slider/cr_slider.js
,
Nov 17
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by aee@chromium.org
, Nov 16Owner: aee@chromium.org
Status: Started (was: Untriaged)