New issue
Advanced search Search tips

Issue 905992 link

Starred by 2 users
Status: Fixed
Owner:
corising@chromium.org
Closed: Nov 28
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
mac-bugs-priority@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Focus highlight of Secure lock icon blinks while entering into full screen.

Reported by sanyam.g...@etouch.net, Nov 16 
Chrome Version:72.0.3612.0 (Official Build) Revision	15e37528e073fa06eb4609e293cadd2afee1021e-refs/branch-heads/3612@{#1} (64-bit)
OS: Mac(10.13.1 , 10.13.6 , 10.14.2) OS

Test-URL: https://permission.site/

Steps to reproduce:
1. Launch chrome, navigate to above URL and check 'Always show Toolbar in Full-screen'.
2. Click on any option(like notification, Location...) on the permission.site page so that permission bubble appears.
3. Now enter into Full-screen mode by clicking on Green icon of Traffic Signal.
4. Observe the focus highlight of secure lock icon while entering into full screen.

Actual  : Focus highlight of Secure lock icon blinks while entering into full screen mode.
Expected: No such blinking should be seen.

This is a regression issue, broken in 'M-71', and below is the bisect info:
Good Build: 71.0.3555.0 (Revision:591861)
Bad Build : 71.0.3556.0 (Revision:592301)

You are probably looking for a change made after 592130 (known good), but no later than 592131 (first known bad).
CHANGE-LOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/e62b9095fe750f3dad440f98c5775c4f6ac4f165..e767f87e7a62609817cff5bce1de36a4d60dfbd5

Suspect: https://chromium.googlesource.com/chromium/src/+/e767f87e7a62609817cff5bce1de36a4d60dfbd5

@corising: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: Issue is not reproducible on Win(7,8,8.1,10) and Linux(14.04 LTS).

Kindly refer the screen-cast for reference.
Thank you..!
Actual_Result.mov
2.9 MB View Download
Expected_Result.mov
2.8 MB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a5ed1eda76feea0619938451bdf41dcfe6216056

commit a5ed1eda76feea0619938451bdf41dcfe6216056
Author: Caroline Rising <corising@chromium.org>
Date: Wed Nov 28 18:13:23 2018

Fix button highlight flashing when entering fullscreen.

This change prevents unhighlighting if the anchor button has not changed. Highlighting was added to a button when a widget is anchored to that button. On entering fullscreen, a widget's anchor is reset regardless of whether it was changed. This would unhighlight then rehighlight the button but only be noticable on Mac.

Bug:  905992 
Change-Id: I4989a45101c704105f5b4a572e028c851b6165b7
Reviewed-on: https://chromium-review.googlesource.com/c/1351106
Commit-Queue: Caroline Rising <corising@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611778}
[modify] https://crrev.com/a5ed1eda76feea0619938451bdf41dcfe6216056/ui/views/bubble/bubble_dialog_delegate_view.cc

Comment 2 by corising@chromium.org, Nov 28

Status: Fixed (was: Assigned)

Comment 3 by sanyam.g...@etouch.net, Nov 29

Labels: TE-Verified-M72 TE-Verified-72.0.3625.0
Update:
Rechecked this issue on  Mac(10.13.1, 10.13.6, 10.14.2)  machines using latest Canary #72.0.3625.0 and issue is fixed. Hence adding TE-Verified labels.

Please refer the attached screen-cast for reference.

Thank you.
Fixed_Result.mov
2.4 MB View Download
►

Sign in to add a comment