Regression: [Extensions] Dev-mode buttons can be wrapped beyond the dev drawer bounds
Reported by
dchau...@etouch.net,
Nov 16
|
||||||||
Issue descriptionChrome Version: 70.0.3538.110 (Official Build) Revision ca97ba107095b2a88cf04f9135463301e685cbb0-refs/branch-heads/3538@{#1094} (32/64-bit) OS: Windows (7, 8, 8.1, 10). What steps will reproduce the problem? 1. Launch Chrome, change browser language to Hindi and relaunch the chrome. 2. Navigate to chrome://extensions page and enable the 'Developer mode' toggle button. 3. Now completely resize the browser from RHS to LHS and observe the 'Update' button. Actual: 'Update' button appears to be chopped and looks weird. Expected: 'Update' button should seen properly. This is a regression issue, broken in M-68 series, below is manual regression range: Good build: 68.0.3406.0 (Revision: 553302) Bad build: 68.0.3409.0 (Revision: 553714) Using the 'per-revision' script providing the bisect result: You are probably looking for a change made after 553380 (known good), but no later than 553381 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/b3d7ea8cb1769efdcc5ba3a3a8a359f0a42366a0..cf71828f1a3b7d1236d3d3c24982df9d830e829d Suspecting: https://chromium.googlesource.com/chromium/src/+/cf71828f1a3b7d1236d3d3c24982df9d830e829d @rdevlin.cronin: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: 1. This issue is also reproducible on Stable #70.0.3538.102 & Beta #71.0.3578.53 and Canary 72.0.3612.0 2. This issue is not seen on Mac (10.13.1, 10.13.6, 10.14.2) and Linux (14.04 LTS) OS. Kindly review the attached screen-cast for reference. Thank you.
,
Nov 16
IIUC, the "expected" behavior is similarly broken as the "actual" one, no? In the expected video, the buttons that wrap are not visible at all, where as in the actual, at least the top part of the 2nd button is shown. Either way, I don't think this is something generic that applies to other surfaces as a result of visual refresh. I also don't think this is a P1 bug, so downgrading. @aee: IIRC you worked on the dev mode drawer. Can you take a look?
,
Nov 16
> IIUC, the "expected" behavior is similarly broken as the "actual" one, no? In the expected video, the buttons that wrap are not visible at all, where as in the actual, at least the top part of the 2nd button is shown. Yep, I think they're both broken. > I also don't think this is a P1 bug, so downgrading. Agreed - removing labels.
,
Nov 17
The dev drawer has a fixed height of 56px. We could make it dynamic.
,
Nov 17
Removing localization since this is not language-specific.
,
Nov 21
,
Nov 22
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3849df4eed565b2119a29bd9c761ae841aa26a52 commit 3849df4eed565b2119a29bd9c761ae841aa26a52 Author: Esmael El-Moslimany <aee@chromium.org> Date: Thu Nov 22 12:49:50 2018 Extensions WebUI: when window is very narrow such that the dev drawer buttons wrap, show scroll Bug: 905991 Change-Id: I63668926091cb84a9ba11c2c4a8310f54883ccbf Reviewed-on: https://chromium-review.googlesource.com/c/1347200 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#610392} [modify] https://crrev.com/3849df4eed565b2119a29bd9c761ae841aa26a52/chrome/browser/resources/md_extensions/toolbar.html
,
Nov 22
,
Nov 23
Update: Rechecked this issue on Windows(7,8,8.1,10) machines using latest Canary #72.0.3619.0 and issue is fixed. Hence adding TE-Verified labels. please refer the attached screen-cast for reference. Thank you. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rdevlin....@chromium.org
, Nov 16Components: -Platform>Extensions UI>Browser>ExtensionsManagement
Owner: dpa...@chromium.org