New issue
Advanced search Search tips

Issue 905971 link

Starred by 3 users

Issue metadata

Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Task


Sign in to add a comment

OOR-CORS: Field Trial

Project Member Reported by toyoshim@chromium.org, Nov 16

Issue description

This is filed to track OOR-CORS field trials.
 
Blocking: 736308
50%:50% canary/dev finch will start from 72.0.3616.0
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/da99e0ac60db3cdec56fe0d9142022e6050ea78e

commit da99e0ac60db3cdec56fe0d9142022e6050ea78e
Author: Takashi Toyoshima <toyoshim@chromium.org>
Date: Mon Nov 19 13:22:04 2018

OOR-CORS: rename the feature name

Bug: 905971
Change-Id: I305358199844ecb0858bbd74e6fd4b888bf63966
Reviewed-on: https://chromium-review.googlesource.com/c/1341782
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609264}
[modify] https://crrev.com/da99e0ac60db3cdec56fe0d9142022e6050ea78e/services/network/public/cpp/features.cc
[modify] https://crrev.com/da99e0ac60db3cdec56fe0d9142022e6050ea78e/third_party/WebKit/LayoutTests/VirtualTestSuites
[modify] https://crrev.com/da99e0ac60db3cdec56fe0d9142022e6050ea78e/tools/metrics/histograms/enums.xml

Please see  Issue 907018 .  This may have broken youtube video playback and tv.youtube.com.  Thanks!
I am on 72.0.3616.0. Since the update, I have the similar problem as said on  Issue 907018  on YouTube. I thought it's the problem with YouTube specifically since the problem only occured in regular mode. So, I reported the problem with screenshots and some technical details on YouTube forum:

https://productforums.google.com/forum/#!topic/youtube/uD9Z6oRmNB8

But, I just had the same problem on passwords.google.com where the button images are square block and the web console giving out the same error as in YouTube's case.
Thank you for reporting.

Also, let me repeat my announcement at chromium groups

----
I and yhirano@ has been worked on OOR-CORS, and now start 50:50 field study in Canary/Dev channels from the next update (72.0.3616.0 and newer versions).

We know still some tests fail when the feature is enabled by default, and need to fix them before launching it. But major issues are solved, and now is the time to evaluate performance and stability, and to find something we may have missed.

If you find something wrong, please let us know. If you prefer to file a bug, here are information you want to fill up in the bug.
 - Owner: toyoshim@ or yhirano@ chromium.org
 - Components: Blink>Loader, Blink>SecurityFeature>CORS
 - Labels: OOR-CORS

Our feature name is "OutOfBlinkCors". You will be able to control the feature via --enable-features=OutOfBlinkCors, or --disable-...

If your client is in the testing group, chrome://version will have 913f596c-3f4a17df in the variations field.
Blockedon: 907261
Blockedon: 907018
if you are seeing x-client-data check errors, please see the 907018
Blockedon: 908324
Blockedon: 908261
Blockedon: 891891
Blockedon: 909639
Blockedon: 909645
Blockedon: 909685
https://docs.google.com/spreadsheets/d/1bOjNUrQEpxzirkoCQ0mVV2grUgvHdS_l_OcuG-azpNY/edit?usp=sharing

Known issue list is here.

All failed non-layout tests were inspected today.
Following two tests are potentially real issues, and others are testing-only issues, or issues that I already have a WIP fix.

ExtensionActiveTabTest/ExtensionActiveTabTest.ActiveTab
ExtensionApiTest.FileURLs (only without NetworkService)

We also monitor performance, but no regressions, or slightly better results are observed.
Blockedon: 906536
 Issue 906536  is blocking (actually the test is missing).
Blocking: 644238
Blockedon: 914968

Sign in to add a comment