Closure compile providers_model_unittest |
||
Issue descriptionRemove html test file. Closure compile unittest and deps.
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82e13c27cd285f191257d4c719c2ee82c77f6857 commit 82e13c27cd285f191257d4c719c2ee82c77f6857 Author: Noel Gordon <noel@chromium.org> Date: Mon Nov 19 23:05:41 2018 Closure compile providers_model_unittest - use let and const and add doc comment annotations. - update LoadTimeData fake to include DRIVE_OFFLINE_COLLECTION_LABEL and DRIVE_SHARED_WITH_ME_COLLECTION_LABEL to avoid JS exceptions about them being missing / undefined when running the unittest. - rm duplicate NOT_MOUNTED_SINGLE_PROVIDING_EXTENSION definition. - use VolumeManagerCommon.Source types rather than bare strings. - create & install mock chrome.fileManagerPrivate. - create & install mock VolumeManager. - run JS formatter over the code. Bug: 905933 Change-Id: I7dabbb8ff72f79d290eaeffcb941280715f93660 Reviewed-on: https://chromium-review.googlesource.com/c/1343397 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by: Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#609487} [modify] https://crrev.com/82e13c27cd285f191257d4c719c2ee82c77f6857/chrome/browser/chromeos/file_manager/file_manager_jstest.cc [modify] https://crrev.com/82e13c27cd285f191257d4c719c2ee82c77f6857/ui/file_manager/file_manager/foreground/js/BUILD.gn [delete] https://crrev.com/03cf59212a842c0c265aac64374a1ed40aca50e2/ui/file_manager/file_manager/foreground/js/providers_model_unittest.html [modify] https://crrev.com/82e13c27cd285f191257d4c719c2ee82c77f6857/ui/file_manager/file_manager/foreground/js/providers_model_unittest.js
,
Nov 19
|
||
►
Sign in to add a comment |
||
Comment 1 by noel@chromium.org
, Nov 19