https://chromium-review.googlesource.com/c/chromium/src/+/1348874

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/604f24648920ec3f475ef7733dbb14ff37e2abb8

commit 604f24648920ec3f475ef7733dbb14ff37e2abb8
Author: Noel Gordon <noel@chromium.org>
Date: Fri Nov 23 00:01:54 2018

Closure compile media_scanner_unittest

 - remove media_scanner_unittest.html, update build rules to closure
   compile this unittest, auto-generate this unittest file.
 - fix closure type errors (the test mocks and unittest code diverged
   from the real world over time, sadly), fix or add commentary.
 - import*ScanResults => import*ScanResult, the former is undefined.
 - scanDirectory|File require a |mode| argument per the externs, so
   add it everywhere.
 - re-order the test media scan and scan result class definitions to
   follow the definition order of their extern file.
 - run the js formatter over the code.

Bug:  905931 
Change-Id: I27239333e2ab2d8bc1c50c6bcade75cc2d6b6701
Reviewed-on: https://chromium-review.googlesource.com/c/1348874
Reviewed-by: Stuart Langley <slangley@chromium.org>
Commit-Queue: Noel Gordon <noel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610506}
[modify] https://crrev.com/604f24648920ec3f475ef7733dbb14ff37e2abb8/chrome/browser/chromeos/file_manager/file_manager_jstest.cc
[modify] https://crrev.com/604f24648920ec3f475ef7733dbb14ff37e2abb8/ui/file_manager/file_manager/background/js/BUILD.gn
[delete] https://crrev.com/7dd3be88c7e2a88aa350f5c3eb9191dcd686251a/ui/file_manager/file_manager/background/js/media_scanner_unittest.html
[modify] https://crrev.com/604f24648920ec3f475ef7733dbb14ff37e2abb8/ui/file_manager/file_manager/background/js/media_scanner_unittest.js
[modify] https://crrev.com/604f24648920ec3f475ef7733dbb14ff37e2abb8/ui/file_manager/file_manager/background/js/mock_media_scanner.js
[modify] https://crrev.com/604f24648920ec3f475ef7733dbb14ff37e2abb8/ui/file_manager/file_manager/background/js/test_import_history.js

Question in review about using js_type_check("test_support") for the test library targets (namely, test_import_history and mock_media_scanner) and adding to the closure_compile group.

No docs on that approach atm, so will deal with it offline.  Anyho.

Re-open, Stu has a patch for ^^^ coming.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0f54940dca1b5028edd54fb5a4d105d70c30b97a

commit 0f54940dca1b5028edd54fb5a4d105d70c30b97a
Author: Stuart Langley <slangley@google.com>
Date: Fri Nov 23 00:43:48 2018

Create build target to type check test support libraries.

Bug:  905932 . 905931
Change-Id: I8a22dd234bd755038b557d896bba0a8981c0e58e
Reviewed-on: https://chromium-review.googlesource.com/c/1348877
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#610507}
[modify] https://crrev.com/0f54940dca1b5028edd54fb5a4d105d70c30b97a/ui/file_manager/file_manager/background/js/BUILD.gn

With these patches done, two other importer/scanner-related unittests that are not closure compiled, and have no bugs, could be ...