async/await is a useful JS feature that would make code nicer in our WebUIs. Current blockers for support: - Rolling uglify-es - Updating the style guide Discussion: https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/chromium-dev/KCGiv5vGeEQ/Y_9OZVtpAAAJ
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8441de078324f383006411014683bd9508b33ff3 commit 8441de078324f383006411014683bd9508b33ff3 Author: Christopher Lam <calamity@chromium.org> Date: Mon Nov 19 03:10:34 2018 WebUI: Roll uglify-es to version 3.3.9. This rolls uglify-es to a version that has async/await support. Bug: 905927 Change-Id: I76ff7048a42c5915534bdcd43549460a713ea886 Reviewed-on: https://chromium-review.googlesource.com/c/1339085 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#609168} [modify] https://crrev.com/8441de078324f383006411014683bd9508b33ff3/third_party/node/node_modules.tar.gz.sha1 [modify] https://crrev.com/8441de078324f383006411014683bd9508b33ff3/third_party/node/package.json
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b360ae39353c7e37a981130553e53a50d3167e60 commit b360ae39353c7e37a981130553e53a50d3167e60 Author: Christopher Lam <calamity@chromium.org> Date: Tue Nov 20 02:01:10 2018 [styleguide/web] Add ES7/8 features. This CL adds ES7/8 features to the ES styleguide, and renames it es.md in light of its more generic nature. All features are To Be Discussed except Async Functions which are allowed. Bug: 671426, 905927 Change-Id: Ib01a7dd3bb5dbcbccf8c262c5210614a4d397594 Reviewed-on: https://chromium-review.googlesource.com/c/1339087 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#609558} [rename] https://crrev.com/b360ae39353c7e37a981130553e53a50d3167e60/styleguide/web/es.md
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12860e7c755ec0e232eff190a727015cf09240b7 commit 12860e7c755ec0e232eff190a727015cf09240b7 Author: Christopher Lam <calamity@chromium.org> Date: Tue Nov 20 05:17:39 2018 [MD Bookmarks] Use async/await. This CL update MD Bookmarks to use async/await where appropriate. Bug: 905927 Change-Id: Ie428db7f543d16dd3b4203892e9f56cadf69ab73 Reviewed-on: https://chromium-review.googlesource.com/c/1339086 Reviewed-by: Alan Cutter <alancutter@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#609601} [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/browser/resources/md_bookmarks/.eslintrc.js [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/browser/resources/md_bookmarks/command_manager.js [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/browser/resources/md_bookmarks/list.js [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/test/data/webui/md_bookmarks/.eslintrc.js [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/test/data/webui/md_bookmarks/app_test.js [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/test/data/webui/md_bookmarks/command_manager_test.js [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/test/data/webui/md_bookmarks/md_bookmarks_focus_test.js [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/test/data/webui/md_bookmarks/policy_test.js [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/test/data/webui/md_bookmarks/router_test.js [modify] https://crrev.com/12860e7c755ec0e232eff190a727015cf09240b7/chrome/test/data/webui/md_bookmarks/test_store.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5f2ad085242cd530fd25b88cbf4b18a475ab7fa commit a5f2ad085242cd530fd25b88cbf4b18a475ab7fa Author: Christopher Lam <calamity@chromium.org> Date: Wed Dec 05 10:05:58 2018 [WebUI] Add ecmaVersion: 2017 to the root .eslintrc.js. This CL adds a parser option to the root .eslintrc.js which is needed for async/await. Since this is now allowed by the style guide, it makes sense to enable the parser option everywhere. Bug: 905927 Change-Id: I6a11032e38602a95c765709a3a998e5cd27c4875 Reviewed-on: https://chromium-review.googlesource.com/c/1343464 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#613924} [modify] https://crrev.com/a5f2ad085242cd530fd25b88cbf4b18a475ab7fa/.eslintrc.js
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/30fe563a6f62e4ae103572a0feaf952a583b3fe4 commit 30fe563a6f62e4ae103572a0feaf952a583b3fe4 Author: Christopher Lam <calamity@chromium.org> Date: Mon Dec 10 14:28:37 2018 [WebUI] Cleanup ecmaVersion 2017 from .eslintrc.js files. This CL removes the ES2017 declaration from directory-specific .eslintrcs since src/.eslintrc.js now declares it. Bug: 905927 Change-Id: If800e42a07a7c36986c0c8220182147eeb73d217 Reviewed-on: https://chromium-review.googlesource.com/c/1369758 Reviewed-by: Sam McNally <sammc@chromium.org> Commit-Queue: calamity <calamity@chromium.org> Cr-Commit-Position: refs/heads/master@{#615113} [delete] https://crrev.com/3f04290dc3a3434dc9f098f8603c3574a343851e/chrome/browser/resources/cryptotoken/.eslintrc.js [modify] https://crrev.com/30fe563a6f62e4ae103572a0feaf952a583b3fe4/chrome/browser/resources/md_bookmarks/.eslintrc.js [modify] https://crrev.com/30fe563a6f62e4ae103572a0feaf952a583b3fe4/chrome/test/data/webui/md_bookmarks/.eslintrc.js [modify] https://crrev.com/30fe563a6f62e4ae103572a0feaf952a583b3fe4/chrome/test/data/webui/md_downloads/.eslintrc.js [delete] https://crrev.com/3f04290dc3a3434dc9f098f8603c3574a343851e/ui/file_manager/integration_tests/.eslintrc.js
Is there anything left to do here?
Comment 1 by bugdroid1@chromium.org
, Nov 19