New issue
Advanced search Search tips
Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Dec 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug
Team-Blink-Paint

Blocking:
issue 905670



Sign in to add a comment
link

Issue 905921: [GeometryInterface] Should be Implement scaleNonUniform() at DOMMatrixReadOnly

Reported by hs1217....@samsung.com, Nov 16 Project Member

Issue description

Comment 1 by jinho.b...@samsung.com, Nov 16

Components: Blink>Geometry
Summary: [GeometryInterface] Should be Implement scaleNonUniform(Self)() at DOMMatrix(ReadOnly) (was: [GeometryInterface] Should be Implement scaleNonUniform () at DOMMatrixReadOnly)

Comment 2 by thalatha...@gmail.com, Nov 16

I want in display finger print lock

Comment 3 by hs1217....@samsung.com, Nov 17

Blocking: 905670

Comment 4 by hs1217....@samsung.com, Nov 17

Summary: [GeometryInterface] Should be Implement scaleNonUniform() at DOMMatrixReadOnly (was: [GeometryInterface] Should be Implement scaleNonUniform(Self)() at DOMMatrix(ReadOnly))
@jinho.bang
according spec change[1], scaleNonUniform was only re-added for legacy reasons.

[1]https://github.com/w3c/fxtf-drafts/commit/b69e666a95f833087217c3783a4d7095d1abfde3#diff-ed7daeb157cd9b31e53896ad3c771a26

Comment 5 by hs1217....@samsung.com, Nov 17

Status: Started (was: Assigned)

Comment 6 by hs1217....@samsung.com, Nov 27

i wrote "Intent to implement and ship" in blink-dev group.
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BJJKDby5p7w

Comment 7 by bugdroid1@chromium.org, Nov 30

Project Member
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/57f350e070536c7870cad53b3edf74f58cc51d50

commit 57f350e070536c7870cad53b3edf74f58cc51d50
Author: Hwanseung Lee <hs1217.lee@samsung.com>
Date: Fri Nov 30 00:33:50 2018

[GeometryInterface] add scaleNonUniform method in DOMMatrixReadOnly

DOMMatrix should be alias to SVGMatrix. (It was not implement in blink yet)
SVGMatrix have scaleNonUniform() function. but DOMMatrix was not.
there are some website which is used SVGMatrix.scaleNonUniform().
it would be possible brake some website when DOMMatrix be alias
to SVGMatrix.

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/BJJKDby5p7w

Bug:  905921 
Change-Id: Ic09b8d6e46d0aa822b766bd6cfbc5ce7c2164849
Reviewed-on: https://chromium-review.googlesource.com/c/1341279
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Reviewed-by: Philip J├Ągenstedt <foolip@chromium.org>
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Reviewed-by: Jinho Bang <jinho.bang@samsung.com>
Cr-Commit-Position: refs/heads/master@{#612473}
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/renderer/core/geometry/dom_matrix_read_only.cc
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/renderer/core/geometry/dom_matrix_read_only.h
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/renderer/core/geometry/dom_matrix_read_only.idl
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/external/wpt/css/geometry/DOMMatrix-002.html
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/external/wpt/css/geometry/DOMMatrix-003.html
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/external/wpt/css/geometry/historical.html
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/external/wpt/css/geometry/interfaces-expected.txt
[delete] https://crrev.com/bc0c4e6775a929cb1358d2690df91831682f6fe0/third_party/blink/web_tests/external/wpt/css/geometry/interfaces.worker-expected.txt
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/fast/dom/geometry-interfaces-dom-matrix-scale-expected.txt
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/fast/dom/geometry-interfaces-dom-matrix-scale.html
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/virtual/stable/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/57f350e070536c7870cad53b3edf74f58cc51d50/third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt

Comment 8 by hs1217....@samsung.com, Dec 3

Status: Fixed (was: Started)

Sign in to add a comment