New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 905919 link

Starred by 2 users
Status: Assigned
Owner:
ssid@chromium.org
Cc:
dominickn@chromium.org
█ bgalbs@google.com
pcovell@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Potential jank caused by AppBannerManagerAndroid at startup

Project Member Reported by ssid@chromium.org, Nov 16 
We collected slow reports from users facing janks and found that the function mentioned above is taking too much time on the main thread, potentially causing janks.

The issue can be found in reports:
3a5a4906746e3264
b807c286ca22528a 
f50c84ad9ac817b7
549c94582bd378ef
0ec495600f47828a
 

Go to crash/ReportID to view the traces.

The stack trace that was hit the most:

__ioctl
<skipped java frames>
banners::AppBannerManagerAndroid::AppBannerManagerAndroid(content::WebContents*)
TabHelpers::AttachTabHelpers(content::WebContents*)
Java_org_chromium_chrome_browser_tab_Tab_nativeInitWebContents



art::ClassLinker::ResolveMethodExceptionHandlerTypes()
banners::AppBannerManagerAndroid::AppBannerManagerAndroid(content::WebContents*)
TabHelpers::AttachTabHelpers(content::WebContents*)
Java_org_chromium_chrome_browser_tab_Tab_nativeInitWebContents
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2788b5d7da99a31115f9337f1e8ff902b0014ace

commit 2788b5d7da99a31115f9337f1e8ff902b0014ace
Author: ssid <ssid@chromium.org>
Date: Fri Nov 16 17:50:49 2018

Add trace event to debug jank in app banners

BUG=905919

Change-Id: I6024a41113845bd6e6b50d829a0ea2b4ab3e5efb
Reviewed-on: https://chromium-review.googlesource.com/c/1336527
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: ssid <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608845}
[modify] https://crrev.com/2788b5d7da99a31115f9337f1e8ff902b0014ace/chrome/browser/ui/tab_helpers.cc

Comment 2 by dtapu...@chromium.org, Nov 16

Components: UI>Browser>WebAppInstalls

Comment 3 by dominickn@chromium.org, Nov 18 

The only thing AppBannerManagerAndroid does at startup is use the JNI to call into Java and create a Java object. I would be unsurprised if there were several other objects doing equal or more amounts of work in a tab helper constructor.

Comment 4 by donnd@chromium.org, Dec 17

Owner: ssid@chromium.org
Status: Assigned (was: Untriaged)
ssid@ can you use the trace landed in #1 to narrow this down and possibly reassign?
►

Sign in to add a comment