New issue
Advanced search Search tips

Issue 905894 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocked on:
issue 890539
issue 905459
issue 905889



Sign in to add a comment

Add presubmit checks for bindings and command buffer generators

Project Member Reported by kbr@chromium.org, Nov 16

Issue description

There have been multiple recent bugs and CLs where dependent files of the ui/gl bindings generator script, or the command buffer generator scripts, have been changed but the generator scripts themselves weren't all run. Recent issues include:

https://chromium-review.googlesource.com/c/chromium/src/+/1292823/13/ui/gl/gl_enums_implementation_autogen.h#1737

Issue 890539

https://chromium-review.googlesource.com/1338724

In order to categorically solve this problem, we need to add a "check" argument to these various generator scripts:

https://chromium.googlesource.com/chromium/src/+/master/ui/gl/generate_bindings.py
https://chromium.googlesource.com/chromium/src/+/master/gpu/vulkan/generate_bindings.py
https://chromium.googlesource.com/chromium/src/+/master/gpu/command_buffer/build_gles2_cmd_buffer.py
https://chromium.googlesource.com/chromium/src/+/master/gpu/command_buffer/build_raster_cmd_buffer.py
https://chromium.googlesource.com/chromium/src/+/master/gpu/command_buffer/build_webgpu_cmd_buffer.py

(any others?)

in similar fashion to how the "check" argument works in this generator script:

https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/generate_buildbot_json.py

and add presubmit checks which invoke these various scripts with the "--check" argument to confirm that the generated files are all up to date.

Blocking on a few affected bugs to establish linkage, but ideally we would add these presubmit checks ASAP.

 

Sign in to add a comment