Picture in Picture: CrOS resize button too close to edge and tap target too small |
|||
Issue descriptionShould follow spec: https://drive.google.com/file/d/1UxiVH5eTqsUdxYYFrP1K231vSurljkaS/view
,
Nov 16
,
Nov 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e259f019cdc3322a09aec51859a6c4bd3eb9a480 commit e259f019cdc3322a09aec51859a6c4bd3eb9a480 Author: Tommy Steimel <steimel@chromium.org> Date: Mon Nov 19 15:25:01 2018 [Picture in Picture] Force resizing when resize handle is clicked This CL changes the hit testing in OverlayWindowViews to force resizing when the user clicks on the resize handle. Before this CL, the resize handle was only used as an indicator of the ability to drag. This CL also increases the size of the resize handler to match the tap target of 36px defined in the spec, while adjusting the icon to adapt to this. This CL also moves the icon slightly away from the corner to match the spec. Bug: 905864 Change-Id: I0d99c2ceff0f00ad51b268aa3803514552044f59 Reviewed-on: https://chromium-review.googlesource.com/c/1338867 Reviewed-by: Evan Stade <estade@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#609300} [modify] https://crrev.com/e259f019cdc3322a09aec51859a6c4bd3eb9a480/chrome/app/vector_icons/resize_handle.icon [modify] https://crrev.com/e259f019cdc3322a09aec51859a6c4bd3eb9a480/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/e259f019cdc3322a09aec51859a6c4bd3eb9a480/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/e259f019cdc3322a09aec51859a6c4bd3eb9a480/chrome/browser/ui/views/overlay/overlay_window_views.h [modify] https://crrev.com/e259f019cdc3322a09aec51859a6c4bd3eb9a480/chrome/browser/ui/views/overlay/resize_handle_button.cc [modify] https://crrev.com/e259f019cdc3322a09aec51859a6c4bd3eb9a480/chrome/browser/ui/views/overlay/resize_handle_button.h
,
Nov 19
|
|||
►
Sign in to add a comment |
|||
Comment 1 by mlamouri@chromium.org
, Nov 16Labels: -Pri-2 Target-72 Pri-1