New issue
Advanced search Search tips

Issue 905847 link

Starred by 2 users
Status: Fixed
Owner:
minch@chromium.org
Closed: Nov 20
Cc:
omrilio@chromium.org
mccanny@chromium.org
minch@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Shelf items in AUTO_HIDE_SHOWN shelf can't be dragged after context menu is opened

Project Member Reported by minch@chromium.org, Nov 15 
Chrome Version: 72.0.3612.0

What steps will reproduce the problem?
(1) Set shelf to auto-hide.
(2) Long press the shelf items until context menu is shown.
(3) Tried to drag the shelf item.

What is the expected result?
Context menu of the shelf item should be closed, shelf should be kept as AUTO_HIDE_SHOWN and shelf item can be dragged out of the shelf.

What happens instead?
Context menu is closed but auto-hide shelf is hidden and shelf item can't be dragged out of the shelf.



Please use labels and text to provide additional information.

If this is a regression (i.e., worked before), please consider using the
bisect tool (https://www.chromium.org/developers/bisect-builds-py) to help
us identify the root cause and more rapidly triage the issue.

For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

Comment 1 by newcomer@chromium.org, Nov 16

Labels: -Pri-2 M-72 Pri-1
Oo interesting. I wonder if the menu closing is what's causing it.

Bumping to P-1 because this makes dragging things around the shelf really hard with autohide enabled because you have to move your finger after the 300ms delay, but before the long press (menu triggering) delay.

Comment 2 by minch@chromium.org, Nov 19

Status: Started (was: Assigned)
Thanks Alex. Yup, the shelf became to hidden because of the menu closed. I am going to fix it.
Project Member

Comment 3 by bugdroid1@chromium.org, Nov 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8292d61079c7dc199a149450701bf63cf6274041

commit 8292d61079c7dc199a149450701bf63cf6274041
Author: Min Chen <minch@google.com>
Date: Tue Nov 20 23:11:09 2018

Items in AUTO_HIDE_SHOWN shelf should can be dragged after context menu is shown.

Changes in this cl:
- Make sure ShelfLayoutManager doesn't handle the following gesture events after
  ET_GESTURE_SCROLL_BEGIN for auto_hide shelf. Then they can still be propagated
  to ShelfButton to process the drag and drop.

- Start the gesture drag and ink drop timer of the shelf item only if the shelf
  is visible. Then gesture drag on the item in AUTO_HIDE_HIDDEN shelf will not
  activate the ink drop of the shelf item.

- Update the shelf visibility in ShelfView::OnMenuClosed only if there is no
  shelf item in drag. Since shelf should be kept as visible during drag even the
  menu is closed.

Bug:  905847 
Change-Id: I384b4c4b3bc2d240820cea338c4ddc59d8cc517a
Reviewed-on: https://chromium-review.googlesource.com/c/1340952
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609842}
[modify] https://crrev.com/8292d61079c7dc199a149450701bf63cf6274041/ash/shelf/shelf.cc
[modify] https://crrev.com/8292d61079c7dc199a149450701bf63cf6274041/ash/shelf/shelf.h
[modify] https://crrev.com/8292d61079c7dc199a149450701bf63cf6274041/ash/shelf/shelf_button.cc
[modify] https://crrev.com/8292d61079c7dc199a149450701bf63cf6274041/ash/shelf/shelf_layout_manager.cc
[modify] https://crrev.com/8292d61079c7dc199a149450701bf63cf6274041/ash/shelf/shelf_view.cc
[modify] https://crrev.com/8292d61079c7dc199a149450701bf63cf6274041/ash/shelf/shelf_view_unittest.cc

Comment 4 by minch@chromium.org, Nov 20

Status: Fixed (was: Started)

Comment 5 by minch@chromium.org, Dec 19

Cc: minch@chromium.org
 Issue 916595  has been merged into this issue.
►

Sign in to add a comment