New issue
Advanced search Search tips

Issue 905839 link

Starred by 1 user
Status: Assigned
Owner:
olivierrobin@chromium.org
Cc:
eugene...@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug-Regression

Blocking:
issue 907153
issue 807428



Sign in to add a comment

ReadingListTestCase/testSavingToReadingListAndLoadBadNetwork fails with WKBasedNavigationManager

Project Member Reported by danyao@chromium.org, Nov 15 
This test started failing after crrev.com/c/1335932 with --enable-features=SlimNavigationManager flag.

ReadingListTestCase/testSavingToReadingListAndLoadBadNetwork:
[1115/093830.046215:WARNING:embedded_test_server.cc(239)] Request not handled. Returning 404: /favicon.ico
[1115/093845.502446:FATAL:offline_page_native_content.mm(106)] Check failed: item && item->GetVirtualURL() == [self virtualURL].
0   ios_chrome_reading_list_egtests     0x000000010ab3c508 base::debug::StackTrace::StackTrace(unsigned long) + 72
1   ios_chrome_reading_list_egtests     0x000000010ab3c53d base::debug::StackTrace::StackTrace(unsigned long) + 29
2   ios_chrome_reading_list_egtests     0x000000010a955fea base::debug::StackTrace::StackTrace() + 26
3   ios_chrome_reading_list_egtests     0x000000010a97f5ee logging::LogMessage::~LogMessage() + 142
4   ios_chrome_reading_list_egtests     0x000000010a97e555 logging::LogMessage::~LogMessage() + 21
5   ios_chrome_reading_list_egtests     0x000000010a2c2cb6 -[OfflinePageNativeContent restoreOnlineURL] + 438
6   ios_chrome_reading_list_egtests     0x000000010a2c2ac7 -[OfflinePageNativeContent reload] + 71
7   ios_chrome_reading_list_egtests     0x000000010986d92c -[CRWWebController reloadWithRendererInitiatedNavigation:] + 636
8   ios_chrome_reading_list_egtests     0x0000000109a7f916 web::WebStateImpl::Reload() + 38
9   ios_chrome_reading_list_egtests     0x00000001098d8524 web::WKBasedNavigationManagerImpl::FinishReload() + 500
10  ios_chrome_reading_list_egtests     0x000000010985bce7 web::NavigationManagerImpl::Reload(web::ReloadType, bool) + 583
11  ios_chrome_reading_list_egtests     0x000000010a925b90 -[ReadingListTestCase testSavingToReadingListAndLoadBadNetwork] + 608
12  CoreFoundation                      0x000000011c52903c __invoking___ + 140
13  CoreFoundation                      0x000000011c5264d5 -[NSInvocation invoke] + 325
14  EarlGrey                            0x000000011d9b67f8 -[GREYTestCaseInvocation invoke] + 104
15  XCTest                              0x000000011c18c018 __24-[XCTestCase invokeTest]_block_invoke.196 + 78
16  XCTest                              0x000000011c1e3c74 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 57
17  XCTest                              0x000000011c1e3b91 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 96
18  XCTest                              0x000000011c18bcd9 __24-[XCTestCase invokeTest]_block_invoke + 848
19  XCTest                              0x000000011c1e9b7e -[XCUITestContext performInScope:] + 248
20  XCTest                              0x000000011c18b8ce -[XCTestCase testContextPerformInScope:] + 98
21  XCTest                              0x000000011c18b97c -[XCTestCase invokeTest] + 137
22  EarlGrey                            0x000000011d9a7447 -[XCTestCase(GREYAdditions) grey_invokeTest] + 1079
23  XCTest                              0x000000011c18d4b7 __26-[XCTestCase performTest:]_block_invoke_2 + 43
24  XCTest                              0x000000011c1e3c74 -[XCTestCase(Failures) performFailableBlock:testCaseRun:shouldInterruptTest:] + 57
25  XCTest                              0x000000011c1e3b91 -[XCTestCase(Failures) _performTurningExceptionsIntoFailuresInterruptAfterHandling:block:] + 96
26  XCTest                              0x000000011c18d3ce __26-[XCTestCase performTest:]_block_invoke.330 + 88
27  XCTest                              0x000000011c1f444b +[XCTContext runInContextForTestCase:block:] + 225
28  XCTest                              0x000000011c18cafd -[XCTestCase performTest:] + 675
29  XCTest                              0x000000011c1d01a2 -[XCTest runTest] + 57
30  XCTest                              0x000000011c187ccb __27-[XCTestSuite performTest:]_block_invoke + 365
31  XCTest                              0x000000011c1874a3 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
32  XCTest                              0x000000011c187766 -[XCTestSuite performTest:] + 296
33  XCTest                              0x000000011c1d01a2 -[XCTest runTest] + 57
34  XCTest                              0x000000011c187ccb __27-[XCTestSuite performTest:]_block_invoke + 365
35  XCTest                              0x000000011c1874a3 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
36  XCTest                              0x000000011c187766 -[XCTestSuite performTest:] + 296
37  XCTest                              0x000000011c1d01a2 -[XCTest runTest] + 57
38  XCTest                              0x000000011c187ccb __27-[XCTestSuite performTest:]_block_invoke + 365
39  XCTest                              0x000000011c1874a3 -[XCTestSuite _performProtectedSectionForTest:testSection:] + 55
40  XCTest                              0x000000011c187766 -[XCTestSuite performTest:] + 296
41  XCTest                              0x000000011c1d01a2 -[XCTest runTest] + 57
42  XCTest                              0x000000011c1ffe86 __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke + 171
43  XCTest                              0x000000011c1fffa7 __44-[XCTTestRunSession runTestsAndReturnError:]_block_invoke.80 + 68
44  XCTest                              0x000000011c19fbc1 -[XCTestObservationCenter _observeTestExecutionForBlock:] + 585
45  XCTest                              0x000000011c1ffbfa -[XCTTestRunSession runTestsAndReturnError:] + 623
46  XCTest                              0x000000011c16c6b6 -[XCTestDriver runTestsAndReturnError:] + 422
47  XCTest                              0x000000011c1f09cd _XCTestMain + 1478
48  libXCTestBundleInject.dylib         0x000000011c155bb8 __copy_helper_block_ + 0
49  CoreFoundation                      0x000000011c48762c __CFRUNLOOP_IS_CALLING_OUT_TO_A_BLOCK__ + 12
50  CoreFoundation                      0x000000011c486de0 __CFRunLoopDoBlocks + 336
51  CoreFoundation                      0x000000011c481654 __CFRunLoopRun + 1284
52  CoreFoundation                      0x000000011c480e11 CFRunLoopRunSpecific + 625
53  GraphicsServices                    0x0000000127a981dd GSEventRunModal + 62
54  UIKitCore                           0x00000001228b481d UIApplicationMain + 140
55  ios_chrome_reading_list_egtests     0x0000000108a4be33 (anonymous namespace)::RunUIApplicationMain(int, char**) + 355
56  ios_chrome_reading_list_egtests     0x0000000108a4b901 main + 417
57  libdyld.dylib                       0x0000000124daf575 start + 1

Comment 1 by eugene...@chromium.org, Nov 15 

crrev.com/c/1335932 has enabled the second part of testSavingToReadingListAndLoadBadNetwork. The failure is expected.
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 15 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42cbbce1449e218024d320135f59470a05ca9373

commit 42cbbce1449e218024d320135f59470a05ca9373
Author: Danyao Wang <danyao@chromium.org>
Date: Thu Nov 15 23:04:03 2018

[Nav Experiment] Temporarily disable broken ReadingListTestCase test.

Bug: 905839
Change-Id: Ib643f63d88ce7a3b6935bda6c37626fee406f2ae
Reviewed-on: https://chromium-review.googlesource.com/c/1338467
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608565}
[modify] https://crrev.com/42cbbce1449e218024d320135f59470a05ca9373/ios/chrome/browser/ui/reading_list/reading_list_egtest.mm

Comment 3 by eugene...@chromium.org, Nov 20

Labels: Proj-WKBackForwardListBlocker

Comment 4 by eugene...@chromium.org, Nov 20

Blocking: 907153

Comment 5 by eugene...@chromium.org, Nov 21

Cc: eugene...@chromium.org
Owner: olivierrobin@chromium.org
►

Sign in to add a comment