New issue
Advanced search Search tips

Issue 905813 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

activating a window during overview mode animation can lead to crash

Project Member Reported by osh...@chromium.org, Nov 15

Issue description

activating a window during overview mode animation can lead to crash
 
Project Member

Comment 1 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6c35095475736406221d8fb47f5119be4bfd508

commit e6c35095475736406221d8fb47f5119be4bfd508
Author: Mitsuru Oshima <oshima@chromium.org>
Date: Fri Nov 16 20:51:25 2018

Cancel Overview first when activation changes

* WindowSelectorObserver listens the activation change first so that
  it can cancel the overview before resuming minimized window.
* This also fixes a crash that happens if you click the overview button
 while activating a window in overview.
* This also fixes the bug in WindowSelectorController was calling wrong
  "Starting/EndingAnimation". This happens to work fine
  because the end results are the same.

Bug:  905813 
Test: covered by unit test. WindowSelectorControllerTest::AnimationCallbacks
Change-Id: I2b3d3fdc2e68bb41c0d037d46552cf6cfda98746
Reviewed-on: https://chromium-review.googlesource.com/c/1338175
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608930}
[modify] https://crrev.com/e6c35095475736406221d8fb47f5119be4bfd508/ash/shell.cc
[modify] https://crrev.com/e6c35095475736406221d8fb47f5119be4bfd508/ash/system/overview/overview_button_tray.cc
[modify] https://crrev.com/e6c35095475736406221d8fb47f5119be4bfd508/ash/wm/overview/window_selector.cc
[modify] https://crrev.com/e6c35095475736406221d8fb47f5119be4bfd508/ash/wm/overview/window_selector.h
[modify] https://crrev.com/e6c35095475736406221d8fb47f5119be4bfd508/ash/wm/overview/window_selector_controller.cc
[modify] https://crrev.com/e6c35095475736406221d8fb47f5119be4bfd508/ash/wm/overview/window_selector_controller.h
[modify] https://crrev.com/e6c35095475736406221d8fb47f5119be4bfd508/ash/wm/overview/window_selector_controller_unittest.cc

Status: Fixed (was: Started)

Sign in to add a comment