New issue
Advanced search Search tips

Issue 905812 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 1
Type: Bug



Sign in to add a comment

[Test crash] MainThreadDefault/ScopedTaskEnvironmentTest.QueuedRunUntilIdle/0 when running *ScopedTaskEnv* in parallel

Project Member Reported by gab@chromium.org, Nov 15

Issue description

The crash is an access violation on the LifetimeObserver |observer->OnScopedTaskEnvironmentCreated| @ altimin

D:\src\chrome\src>out\Release\base_unittests.exe --test-launcher-jobs=42 --gtest_filter=*ScopedTaskEnv*
IMPORTANT DEBUGGING NOTE: batches of tests are run inside their
own process. For debugging a test inside a debugger, use the
--gtest_filter=<your_test_name> flag along with
--single-process-tests.
Using sharding settings from environment. This is shard 0/1
Using 42 parallel jobs.
[1/30] ScopedTaskEnvironmentTest.FastForwardAdvanceTickClock (2 ms)
[2/30] ScopedTaskEnvironmentTest.LifetimeObserver (2 ms)
[ RUN      ] MainThreadDefault/ScopedTaskEnvironmentTest.QueuedRunUntilIdle/0
Received fatal exception EXCEPTION_ACCESS_VIOLATION
Backtrace:
        base::test::ScopedTaskEnvironment::ScopedTaskEnvironment [0x01BC972F+655] (D:/src/chrome/src/out/Release\..\..\base\test\scoped_task_environment.cc:156)
        base::test::`anonymous namespace'::RunUntilIdleTest [0x019B7CC7+47] (D:/src/chrome/src/out/Release\..\..\base\test\scoped_task_environment_unittest.cc:49)
        testing::Test::Run [0x01BB285D+201] (D:/src/chrome/src/out/Release\..\..\third_party\googletest\src\googletest\src\gtest.cc:2522)
        testing::TestInfo::Run [0x01BB30D0+216] (D:/src/chrome/src/out/Release\..\..\third_party\googletest\src\googletest\src\gtest.cc:2707)
        testing::TestCase::Run [0x01BB359F+245] (D:/src/chrome/src/out/Release\..\..\third_party\googletest\src\googletest\src\gtest.cc:2824)
        testing::internal::UnitTestImpl::RunAllTests [0x01BBA06E+632] (D:/src/chrome/src/out/Release\..\..\third_party\googletest\src\googletest\src\gtest.cc:5225)
        testing::UnitTest::Run [0x01BB9CF8+156] (D:/src/chrome/src/out/Release\..\..\third_party\googletest\src\googletest\src\gtest.cc:4835)
        base::TestSuite::Run [0x01C2DF84+102] (D:/src/chrome/src/out/Release\..\..\base\test\test_suite.cc:303)
        base::OnceCallback<int ()>::Run [0x019A9085+43] (D:/src/chrome/src/out/Release\..\..\base\callback.h:99)
        base::`anonymous namespace'::LaunchUnitTestsInternal [0x01C2F40B+274] (D:/src/chrome/src/out/Release\..\..\base\test\launcher\unit_test_launcher.cc:225)
        base::LaunchUnitTests [0x01C2F2D0+184] (D:/src/chrome/src/out/Release\..\..\base\test\launcher\unit_test_launcher.cc:575)
        main [0x01C2DD2C+160] (D:/src/chrome/src/out/Release\..\..\base\test\run_all_base_unittests.cc:12)
        __scrt_common_main_seh [0x01C4186B+250] (f:\dd\vctools\crt\vcstartup\src\startup\exe_common.inl:283)
        BaseThreadInitThunk [0x74A68674+36]
        RtlGetAppContainerNamedObjectPath [0x77905D87+311]
        RtlGetAppContainerNamedObjectPath [0x77905D57+263]
 
Note: it's basically the first test that runs after  ScopedTaskEnvironmentTest.LifetimeObserver that crashes I think (repro'ed without --test-launcher-jobs=42 too).
Project Member

Comment 2 by bugdroid1@chromium.org, Nov 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b3e76c63a1c2cee437da4b1a7c3adda988039b94

commit b3e76c63a1c2cee437da4b1a7c3adda988039b94
Author: Alexander Timin <altimin@chromium.org>
Date: Fri Nov 16 19:45:10 2018

[base] Fix a crash in ScopedTaskEnvironmentTest.LifetimeObserver test.

Call ScopedTaskEnvironment::SetLifetimeObserver(nullptr) to ensure that
the next test after ScopedTaskEnvironmentTest.LifetimeObserver doesn't
crash.

R=gab@chromium.org
BUG=905812

Change-Id: Ifbdcfa55695fbd5641ffccb8d3e60a80d1afb3ca
Reviewed-on: https://chromium-review.googlesource.com/c/1338090
Commit-Queue: Gabriel Charette <gab@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#608899}
[modify] https://crrev.com/b3e76c63a1c2cee437da4b1a7c3adda988039b94/base/test/scoped_task_environment_unittest.cc

Sign in to add a comment