New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905766 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

network_WiFi_RoamFT tests failing on M72 builds.

Project Member Reported by aashuto...@chromium.org, Nov 15

Issue description

network_WiFi_RoamFT.EAP and network_WiFi_RoamFT.PSK test cases failing with "Association timed out" Error

Sample failure:


11/14 15:30:32.784 INFO | site_linux_router:0529| AP configured.
11/14 15:30:32.784 INFO |wifi_test_context_:0254| Connecting to RoamFT_a_szac1_ch1.
11/14 15:30:50.014 DEBUG|      xmlrpc_types:0056| Constructing AssociationResult object with args=[], kwargs={'configuration_time': -1.0, 'association_time': 15.051162958145142, 'discovery_time': 1.0459811687469482, 'success': False, 'failure_reason': 'FAIL(Association timed out)'}
11/14 15:30:50.015 INFO |wifi_test_context_:0262| Finished connection attempt to RoamFT_a_szac1_ch1 with times: discovery=1.05, association=15.05, configuration=-1.00.
11/14 15:30:50.015 DEBUG|              test:0381| Test failed due to Expected connection to RoamFT_a_szac1_ch1 to succeed, but it failed with reason: FAIL(Association timed out)..



Traceback (most recent call last):
  File "/usr/local/autotest/client/common_lib/test.py", line 600, in _exec
    _call_test_function(self.execute, *p_args, **p_dargs)
  File "/usr/local/autotest/client/common_lib/test.py", line 800, in _call_test_function
    return func(*args, **dargs)
  File "/usr/local/autotest/client/common_lib/test.py", line 464, in execute
    postprocess_profiled_run, args, dargs)
  File "/usr/local/autotest/client/common_lib/test.py", line 371, in _call_run_once
    self.run_once(*args, **dargs)
  File "/usr/local/autotest/server/site_tests/network_WiFi_RoamFT/network_WiFi_RoamFT.py", line 119, in run_once
    self.context.assert_connect_wifi(client_conf)
  File "/usr/local/autotest/server/cros/network/wifi_test_context_manager.py", line 273, in assert_connect_wifi
    connect_name, assoc_result.failure_reason))
TestFail: Expected connection to RoamFT_a_szac1_ch1 to succeed, but it failed with reason: FAIL(Association timed out).


Autotest link, 

https://stainless.corp.google.com/search?view=matrix&row=test&col=build&first_date=2018-11-09&last_date=2018-11-15&suite=wifi_endtoend%7Cwifi_matfunc%7Cwifi_perf%7Cwifi_update_router%7Cwifi_release%7Cwifi_lucidsleep&test=network_WiFi_RoamFT&status=GOOD&status=WARN&status=FAIL&status=ERROR&status=ABORT&status=ALERT&status=RUNNING&status=NOSTATUS&exclude_cts=true&exclude_not_run=false&exclude_non_release=true&exclude_au=true&exclude_acts=true&exclude_retried=true&exclude_non_production=true


 
Owner: matthewmwang@chromium.org
Status: Assigned (was: Available)
Ah, this is because I added the global FT switch. Will put in a fix.
There are a whole lot of failures for other reasons too. I'd say this particular failure (and explanation) count for non-mixed variants of the test, but even the RoamFT.mixed<foo> tests are failing plenty often. Please take a look at those on either this bug or a follow-up.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/371e0f5da803aea3543862fe995ed74274b3c7bd

commit 371e0f5da803aea3543862fe995ed74274b3c7bd
Author: Matthew Wang <matthewmwang@chromium.org>
Date: Tue Nov 20 13:52:37 2018

network_WiFi_RoamFT: set WiFi.GlobalFTEnabled property before FT tests

With the addition of the new global FT switch that is off by default,
all of the FT autotests are failing. Flip the FT switch on via dbus so
that these tests pass again.

BUG=chromium:905766
TEST=Ran autotest without the change and it failed. Ran autotest with
     the change and it passed. Ran autotest without the change again
     and it failed again.

Change-Id: I79ab3a762c6e0b2ddda931237d5238377a390b5c
Reviewed-on: https://chromium-review.googlesource.com/1338280
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/371e0f5da803aea3543862fe995ed74274b3c7bd/server/cros/network/wifi_client.py
[modify] https://crrev.com/371e0f5da803aea3543862fe995ed74274b3c7bd/server/site_tests/network_WiFi_RoamFT/network_WiFi_RoamFT.py
[modify] https://crrev.com/371e0f5da803aea3543862fe995ed74274b3c7bd/client/cros/networking/shill_proxy.py

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d27b4d9991b07e6d898f2271b2b5d9dd4e1d33f1

commit d27b4d9991b07e6d898f2271b2b5d9dd4e1d33f1
Author: Matthew Wang <matthewmwang@chromium.org>
Date: Wed Nov 21 13:52:52 2018

network_WiFi_RoamFT: rerun FT mixed mode tests with FT disabled

With the addition of the new global FT switch, we want to ensure that
FT mixed mode tests still work even when the global FT switch on the
DUT is off.

BUG=chromium:905766
TEST=ran all FT tests on caroline DUT and mixed mode tests went
     through the test body twice. Everything passed.

Change-Id: Ib47c36d378f7df28c717d32101dbd6ba675ac3df
Reviewed-on: https://chromium-review.googlesource.com/1341181
Commit-Ready: Matthew Wang <matthewmwang@chromium.org>
Tested-by: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/d27b4d9991b07e6d898f2271b2b5d9dd4e1d33f1/server/cros/network/wifi_client.py
[modify] https://crrev.com/d27b4d9991b07e6d898f2271b2b5d9dd4e1d33f1/server/site_tests/network_WiFi_RoamFT/network_WiFi_RoamFT.py

Labels: -Pri-2 Pri-1
Congratulations, we broke *all* our Wifi tests!

https://bugs.chromium.org/p/chromium/issues/detail?id=812129#c4

We can't use 'shill_proxy' (which uses 'dbus') on server tests. Matthew, can you please move your DBus constant out of that module and drop the import?
Project Member

Comment 7 by bugdroid1@chromium.org, Nov 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/86b819fffa899303d3eb170968e48cb3456664b9

commit 86b819fffa899303d3eb170968e48cb3456664b9
Author: Matthew Wang <matthewmwang@chromium.org>
Date: Thu Nov 22 06:49:11 2018

Remove shill_proxy import from wifi_client

The import was breaking wifi tests:
https://bugs.chromium.org/p/chromium/issues/detail?id=812129#c4

Removing the import and changing the set_dhcp_property function to be
a set_manager_property function (which it already functionally was) so
that network_WiFi_RoamFT can call it.

BUG=chromium:905766
TEST=Ran all modified tests (network_WiFi_RoamFT.* and
     network_WiFi_SetOptionalDhcpProperties) and everything passed

Change-Id: Ia99ad78d2e282bbd8204913e22dc50690d55f93f
Reviewed-on: https://chromium-review.googlesource.com/1347294
Commit-Ready: Matthew Wang <matthewmwang@chromium.org>
Tested-by: Matthew Wang <matthewmwang@chromium.org>
Reviewed-by: Kirtika Ruchandani <kirtika@chromium.org>
Reviewed-by: Brian Norris <briannorris@chromium.org>

[modify] https://crrev.com/86b819fffa899303d3eb170968e48cb3456664b9/server/site_tests/network_WiFi_SetOptionalDhcpProperties/network_WiFi_SetOptionalDhcpProperties.py
[modify] https://crrev.com/86b819fffa899303d3eb170968e48cb3456664b9/server/cros/network/wifi_client.py
[modify] https://crrev.com/86b819fffa899303d3eb170968e48cb3456664b9/server/site_tests/network_WiFi_RoamFT/network_WiFi_RoamFT.py

Cc: benchan@chromium.org
Tests are still pretty flaky.

Unless you have clear actions to improve this test, it's probably best to move it to suite:wifi_flaky.

On the other hand...you're trying to launch this feature on M72 right? So there needs to be some non-flaky test coverage for this.
Labels: wifi-test-failures
Hmm, so some of the flake is tracked in  bug 907656 . Not sure if that covers everything.
Issue 910046 has been merged into this issue.

Comment 11 by matthewmwang@chromium.org, Today (14 hours ago)

Labels: -ReleaseBlock-Stable
Removing RBS since almost all failures are resolved.

Sign in to add a comment