aura_unittests fails to compile on M71 branch |
||||||||
Issue descriptionA merge to M71 https://crrev.com/c/1330718 causes this failure, since it uses base::BindLambdaForTesting but does not include base/test/bind_test_util.h. It was okay on master since this include was added to the window_event_dispatcher_unittest.cc by another CL after M71 branch.
,
Nov 15
The bug is marked as P3 or Feature. It should not be merged as M71 is in beta. Please contact the approriate milestone owner if you have questions. Owners: benmason@(Android), kariahda@(iOS), kbleicher@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Nov 15
Is the change fully safe to merge to M71 this late in release cycle?
,
Nov 15
,
Nov 15
It's safe because - the change is only for unittest files. No affect on the release binaries. - it only adds an #include line which is missing in the branch, just make a unittest buildable.
,
Nov 15
Approving merge to M71 branch 3578 based on comment #5. Please merge ASAP. Thank you.
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2e984fa9a0b0ab070515be6dc6c6b02f5aaca57 commit f2e984fa9a0b0ab070515be6dc6c6b02f5aaca57 Author: Jun Mukai <mukai@chromium.org> Date: Thu Nov 15 19:28:14 2018 fix aura_unittest compile error on M71 branch The merge crrev.com/c/1330718 was okay on master but it uses an include which was added after M71 branch. Simply adding a new line will fix this. Bug: 905753 Test: autoninja aura_unittests Change-Id: Ibe8d521af799369b3c59d28ba4315967de0e7dda Reviewed-on: https://chromium-review.googlesource.com/c/1337281 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#700} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034} [modify] https://crrev.com/f2e984fa9a0b0ab070515be6dc6c6b02f5aaca57/ui/aura/window_event_dispatcher_unittest.cc
,
Nov 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f2e984fa9a0b0ab070515be6dc6c6b02f5aaca57 Commit: f2e984fa9a0b0ab070515be6dc6c6b02f5aaca57 Author: mukai@chromium.org Commiter: mukai@chromium.org Date: 2018-11-15 19:28:14 +0000 UTC fix aura_unittest compile error on M71 branch The merge crrev.com/c/1330718 was okay on master but it uses an include which was added after M71 branch. Simply adding a new line will fix this. Bug: 905753 Test: autoninja aura_unittests Change-Id: Ibe8d521af799369b3c59d28ba4315967de0e7dda Reviewed-on: https://chromium-review.googlesource.com/c/1337281 Reviewed-by: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/branch-heads/3578@{#700} Cr-Branched-From: 4226ddf99103e493d7afb23a4c7902ee496108b6-refs/heads/master@{#599034}
,
Nov 15
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by mukai@chromium.org
, Nov 15Labels: Merge-Request-71