To transition from CIDB to BuildBucket, we need to define the functions that absolutely have to be supported through BuildBucket interface. This bug tracks the first step in the process.
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/ae57ced21615842cd56bff92403fe2074ed28492 commit ae57ced21615842cd56bff92403fe2074ed28492 Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Wed Nov 21 09:25:22 2018 cidb: Delete unused functions CIDBConnection has four functions that are never used. Gasp! dburger has a CL for GetSlaveBuildMessages. This CL deletes the other three so that the transition from cidb to buildbucket is smoother. The functions are - GetManifestVersions, GetActionsSince and GetBuildRequestsForBuildConfig BUG=chromium:905751 TEST=tryjob Change-Id: I76cf809fc6c629ab9a3ed235ecb199adfc3b0e64 Reviewed-on: https://chromium-review.googlesource.com/1338499 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/ae57ced21615842cd56bff92403fe2074ed28492/lib/fake_cidb.py [modify] https://crrev.com/ae57ced21615842cd56bff92403fe2074ed28492/lib/cidb_integration_test.py [modify] https://crrev.com/ae57ced21615842cd56bff92403fe2074ed28492/lib/cidb.py [modify] https://crrev.com/ae57ced21615842cd56bff92403fe2074ed28492/cbuildbot/stages/sync_stages_unittest.py [modify] https://crrev.com/ae57ced21615842cd56bff92403fe2074ed28492/cbuildbot/stages/scheduler_stages_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/71928dd258ca1902b8baa679c14b4ff2ab544668 commit 71928dd258ca1902b8baa679c14b4ff2ab544668 Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Thu Dec 06 13:54:38 2018 lib/cidb.py: Delete functions used in bad_cl_detector infra/bad_cl_detector uses 3 functions exclusively. This CL deletes those functions, as there is no plan for further progress or use from that project. The functions: 1) GetMasterStages 2) GetAnnotatedBuilds 3) GetFailuresForChange BUG=chromium:905751 TEST=tryjob Change-Id: I66453b4e048aabe931b71cb7b4c74e9e83ac023e Reviewed-on: https://chromium-review.googlesource.com/1362082 Commit-Ready: Dhanya Ganesh <dhanyaganesh@chromium.org> Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/71928dd258ca1902b8baa679c14b4ff2ab544668/lib/cidb.py [modify] https://crrev.com/71928dd258ca1902b8baa679c14b4ff2ab544668/lib/cidb_integration_test.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/infra/bad_cl_detector/+/08bb5589019bbaae1039240ce347cdc3ed05f43a commit 08bb5589019bbaae1039240ce347cdc3ed05f43a Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Fri Dec 07 06:06:45 2018 README: Notice of function removal Chromite has removed functions used exclusively by this project. BUG=chromium:905751 TEST=na Change-Id: I0c10827fe81a4e9b0f0b46140b7f0cdb4de02dd8 Reviewed-on: https://chromium-review.googlesource.com/1361943 Commit-Ready: Dhanya Ganesh <dhanyaganesh@chromium.org> Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/08bb5589019bbaae1039240ce347cdc3ed05f43a/README.md
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/f55b6a5106256f540ecb7653cfdeb7b178ecbebf commit f55b6a5106256f540ecb7653cfdeb7b178ecbebf Author: David Burger <dburger@chromium.org> Date: Thu Jan 03 02:14:04 2019 Remove constants now unused with removal of GetAnnotatedBuilds Remove a couple of constants that are now unused with the removal of the unused cidb method GetAnnotatedBuilds in https://chromium.googlesource.com/chromiumos/chromite/+/71928dd258ca1902b8baa679c14b4ff2ab544668. BUG=chromium:905751 TEST=./run_tests TEST=./lib/cidb_integration_test Change-Id: I070444eb9ae97966a46116cd59c1ac62a108d39e Reviewed-on: https://chromium-review.googlesource.com/1393290 Commit-Ready: David Burger <dburger@chromium.org> Tested-by: David Burger <dburger@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/f55b6a5106256f540ecb7653cfdeb7b178ecbebf/lib/cidb.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/3cc81eaa6ede9990bcfe90b3d5de615c6e31b4a0 commit 3cc81eaa6ede9990bcfe90b3d5de615c6e31b4a0 Author: David Burger <dburger@chromium.org> Date: Thu Jan 03 23:04:23 2019 Remove unused cidb method GetMetadata Remove the now used cidb method GetMetadata. BUG=chromium:905751 TEST=./run_tests TEST=./lib/cidb_integration_test --debug Change-Id: Ib527ad704741d90ea58821ae27d2e256518c2239 Reviewed-on: https://chromium-review.googlesource.com/1393497 Commit-Ready: David Burger <dburger@chromium.org> Tested-by: David Burger <dburger@chromium.org> Reviewed-by: Dhanya Ganesh <dhanyaganesh@chromium.org> [modify] https://crrev.com/3cc81eaa6ede9990bcfe90b3d5de615c6e31b4a0/lib/cidb.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/84fe948c97a95c980ac0d6c01d41e6a82d88922f commit 84fe948c97a95c980ac0d6c01d41e6a82d88922f Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Wed Jan 09 07:25:58 2019 lib/cidb.py: Remove GetSlaveStages Instead use GetBuildsStages and GetSlaveStatus to get the same functionality. The resulting interface will be much cleaner. GetBuildStatusWithBuildbucketId had to be modified to accept multiple Buildbucket IDs. BUG=chromium:905751 TEST=tryjob Change-Id: Id4c271a6f055f0f32f1aa8ca315fc4f999b44258 Reviewed-on: https://chromium-review.googlesource.com/1387874 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/cbuildbot/relevant_changes.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/lib/cidb.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/cbuildbot/relevant_changes_unittest.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/cbuildbot/stages/completion_stages.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/cbuildbot/stages/sync_stages.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/cbuildbot/stages/completion_stages_unittest.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/cli/cros/cros_buildresult.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/cbuildbot/stages/handle_changes_stages.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/lib/fake_cidb.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/lib/cidb_integration_test.py [modify] https://crrev.com/84fe948c97a95c980ac0d6c01d41e6a82d88922f/cbuildbot/stages/handle_changes_stages_unittest.py
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/chromite/+/9e5c9014937e8e477f42b0de84e17a1399276221 commit 9e5c9014937e8e477f42b0de84e17a1399276221 Author: Dhanya Ganesh <dhanyaganesh@chromium.org> Date: Thu Jan 10 21:58:45 2019 lib/cidb.py: Remove GetSlaveFailures Instead use GetBuildsFailures and GetSlaveStatus to get the same functionality. The resulting interface will be much cleaner. BUG=chromium:905751 TEST=tryjob Change-Id: I82349fcee093229b252743070b49dabc9d84808d Reviewed-on: https://chromium-review.googlesource.com/1396258 Commit-Ready: Dhanya Ganesh <dhanyaganesh@chromium.org> Tested-by: Dhanya Ganesh <dhanyaganesh@chromium.org> Reviewed-by: Jason Clinton <jclinton@chromium.org> [modify] https://crrev.com/9e5c9014937e8e477f42b0de84e17a1399276221/cbuildbot/stages/report_stages_unittest.py [modify] https://crrev.com/9e5c9014937e8e477f42b0de84e17a1399276221/lib/cidb.py [modify] https://crrev.com/9e5c9014937e8e477f42b0de84e17a1399276221/lib/builder_status_lib_unittest.py [modify] https://crrev.com/9e5c9014937e8e477f42b0de84e17a1399276221/lib/builder_status_lib.py [modify] https://crrev.com/9e5c9014937e8e477f42b0de84e17a1399276221/cbuildbot/stages/report_stages.py [modify] https://crrev.com/9e5c9014937e8e477f42b0de84e17a1399276221/lib/cidb_integration_test.py
Comment 1 by dhanyaganesh@chromium.org
, Nov 15