New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905750 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 20
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug

Blocking:
issue 901910



Sign in to add a comment

[Findit] Flake Analyzer - Implement post-analysis bug deduplication logic

Project Member Reported by lijeffrey@chromium.org, Nov 15

Issue description

After a FlakeCulprit has been identified, if it is already associated with a flake issue yet the analysis that identified the culprit has a different flake issue, merge the 2nd one into the 1st
 
Blocking: 901910
Project Member

Comment 2 by Findit, Dec 13

Cc: lijeffrey@chromium.org
 Issue 914901  has been merged into this issue.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 18

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/e812df2abf9e1c8a420abcc36d81ec491395e6c3

commit e812df2abf9e1c8a420abcc36d81ec491395e6c3
Author: Jeffrey Li <lijeffrey@chromium.org>
Date: Tue Dec 18 22:25:53 2018

[Findit] Flake Analyzer - Merge duplicate issues by culprit

Scenario:
FlakeCuprit is already pointing to a FlakeIssue. An incoming analysis
with a different Flake/FlakeIssue arrives at the same culprit.

1. If 1 issue was created by Findit while the other by a human, always
   merge into the human-created issue
2. Otherwise, merge into the culprit's existing issue.
3. FlakeCulprit is always pointing to the most up-to-date FlakeIssue
4. FlakeIssue's merge_destination_key is to be set upon deduplication
5. Calling code responsible for handling updating FlakeIssues impacted
   by deduplication (e.g. in OnFlakeCulpritIdentified).

Bug:  905750 
Change-Id: I22818f5cdcd9535b47baa79f8336dece4cf72413
Reviewed-on: https://chromium-review.googlesource.com/c/1356852
Reviewed-by: Chan Li <chanli@chromium.org>
Commit-Queue: Jeffrey Li <lijeffrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#19645}
[modify] https://crrev.com/e812df2abf9e1c8a420abcc36d81ec491395e6c3/appengine/findit/services/issue_constants.py
[modify] https://crrev.com/e812df2abf9e1c8a420abcc36d81ec491395e6c3/appengine/findit/services/test/monorail_util_test.py
[modify] https://crrev.com/e812df2abf9e1c8a420abcc36d81ec491395e6c3/appengine/findit/services/actions/flake_analysis_actions.py
[modify] https://crrev.com/e812df2abf9e1c8a420abcc36d81ec491395e6c3/appengine/findit/services/test/issue_generator_test.py
[modify] https://crrev.com/e812df2abf9e1c8a420abcc36d81ec491395e6c3/appengine/findit/services/actions/test/flake_analysis_actions_test.py
[modify] https://crrev.com/e812df2abf9e1c8a420abcc36d81ec491395e6c3/appengine/findit/services/monorail_util.py
[modify] https://crrev.com/e812df2abf9e1c8a420abcc36d81ec491395e6c3/appengine/findit/model/flake/flake_issue.py
[modify] https://crrev.com/e812df2abf9e1c8a420abcc36d81ec491395e6c3/appengine/findit/services/flake_issue_util.py
[modify] https://crrev.com/e812df2abf9e1c8a420abcc36d81ec491395e6c3/appengine/findit/services/issue_generator.py

Status: Fixed (was: Assigned)

Sign in to add a comment