Issue metadata
Sign in to add a comment
|
Most Visited tiles are not removed after Clear Browsing Data |
||||||||||||||||||||||
Issue descriptionApp Version: 72.0.3611.0 canary iOS Version: 11.4.1, 12.1 Device: iPhone6s, iPhoneX URL: NA Precondition: Enable #browser-container-contains-ntp flag (If its not enabled already by default) Steps to reproduce: 1. Launch Google Chrome 2. Navigate to few websites 3. Enter tab switcher and Close All tabs 4. Open New Tab Page 5. Make sure you see the most visited tiles in the NTP 6. Tap Menu → Settings → Privacy → ClearBrowsingData → ClearBrowsingData 7. Dismiss Settings Observed results: Most visited tiles in the current NTP are not cleared. Navigating to a new NTP fixes the issue. Note: Also issue is NOT reproduced if the flag #browser-container-contains-ntp is disabled. Expected results: Most visited title should be cleared immediately. Number of times you were able to reproduce: 5/5 Bug reproducible after clean install: Yes Bug reproducible after clearing cache and cookies: Yes Bug reproducible on Chrome Mobile on Android: Bug reproducible on Safari/Firefox: Firefox: , Safari: Bug reproducible on current stable build (App Version, iOS Version): M70 NO Bug reproducible on the current beta channel build (App Version, iOS Version): M71 NO Link to video/image: https://drive.google.com/file/d/18WHvrH0_WinU13IkQT6My8SIcDkLi4oW/view
,
Nov 15
,
Nov 16
,
Nov 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5367e5e7097ffc377ff9d7b3ae41db85b8ea9d40 commit 5367e5e7097ffc377ff9d7b3ae41db85b8ea9d40 Author: Justin Cohen <justincohen@google.com> Date: Fri Nov 16 21:17:13 2018 [ios] Stop the NTP on web usage toggle. This happens when clearing browser data, and forces the NTP to be recreated (and not show previous NTP tiles). Bug: 905735 Change-Id: If818e02703c7324f0a660bf6b115603db3682b74 Reviewed-on: https://chromium-review.googlesource.com/c/1339340 Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#608947} [modify] https://crrev.com/5367e5e7097ffc377ff9d7b3ae41db85b8ea9d40/ios/chrome/browser/ntp_tiles/ntp_tiles_egtest.mm [modify] https://crrev.com/5367e5e7097ffc377ff9d7b3ae41db85b8ea9d40/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/5367e5e7097ffc377ff9d7b3ae41db85b8ea9d40/ios/chrome/test/earl_grey/chrome_matchers.h [modify] https://crrev.com/5367e5e7097ffc377ff9d7b3ae41db85b8ea9d40/ios/chrome/test/earl_grey/chrome_matchers.mm
,
Nov 17
,
Nov 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8a50746fbd61f454d7ef1b4df46d964c0cf78b12 commit 8a50746fbd61f454d7ef1b4df46d964c0cf78b12 Author: Justin Cohen <justincohen@google.com> Date: Sun Nov 18 21:18:28 2018 [ios] Fix testTopSitesTileAfterRedirect on iPad. Fixes some flake in the EG tests, and catches an error in the previous CL crrev.com/c/1339340. The NTP should not be created while web usage is disabled. Bug: 905735 Change-Id: I8bd3d942c3594e4706e29ed0478a935a10602727 Reviewed-on: https://chromium-review.googlesource.com/c/1341208 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#609148} [modify] https://crrev.com/8a50746fbd61f454d7ef1b4df46d964c0cf78b12/ios/chrome/browser/ntp_tiles/ntp_tiles_egtest.mm [modify] https://crrev.com/8a50746fbd61f454d7ef1b4df46d964c0cf78b12/ios/chrome/browser/ui/browser_view_controller.mm
,
Nov 20
Issue verified Version: Chrome Canary 72.0.3616.0 Device: iPhone XS iOS: 12.1 Most visited tiles correctly removed https://drive.google.com/open?id=1FzsFU1deJbisbOWNcTS6nloyGJzZO3oV |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by justincohen@chromium.org
, Nov 15