New issue
Advanced search Search tips

Issue 905733 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

[UserTimingL3] Feature detection: API does not return the entry

Project Member Reported by maxlg@chromium.org, Nov 15

Issue description

UserTimingL3 uses returned value for feature detection. If measure and mark API returns null, the APIs are L2 API; If the APIs return an entry, the APIs are L3 API.

However, in the current implementation, when L3 API is disabled, the APIs do not always return the null.

Use case 1:
Repro steps (when CustomUserTiming is disabled):
1. Open console
2. performance.mark("name")
 
Expected:
return undefined
 
Actual:
return PerformanceMark entry

Use case 2:
Repro steps (when CustomUserTiming is disabled):
1. Open console
2. performance.measure("name")
 
Expected:
return undefined
 
Actual:
return PerformanceMeasure entry
 
Do you have a repro?

Comment 2 Deleted

Summary: [UserTimingL3] Feature detection: API does not return the entry (was: [UserTimingL3] Feature detection: API does not always return the entry)
I think the point is that in L3 it needs to return the entry whereas it was a void method. https://chromium-review.googlesource.com/c/chromium/src/+/1338225 fixes this (but the CL does not reference this bug).

Max, is this fixed?
Description: Show this description
Description: Show this description
Status: Fixed (was: Assigned)

Sign in to add a comment