New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905719 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Fix /mnt/stateful_partition/encrypted/var/cache/camera user

Project Member Reported by hidehiko@chromium.org, Nov 15

Issue description

If the dir is created via chrome_setup,

https://chromium.git.corp.google.com/chromiumos/platform2/+/41ee42a45023b65503fa5ec78d848272033288d9/login_manager/chrome_setup.cc#295

it looks arc-camera user. Though if it is created via generate_camera_profile via arc-setup

https://chromium.git.corp.google.com/chromiumos/platform/arc-camera/+/e35241c4164ad6c1a9280ff42492323e9e3fab39/tools/generate_camera_profile.cc#110

it looks root user.

I think we should fix the user...? WDYT, jcliang@?

 
Cc: henryhsu@chromium.org
Yes, we should fix it and make it consistent. The user should be arc-camera.
Status: Assigned (was: Untriaged)
Owner: inker@chromium.org
Inker - Could you help fix the owner/group of the directory in arc_setup?
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/c6b7fb69842f05f444963006b56eed34dff4fe00

commit c6b7fb69842f05f444963006b56eed34dff4fe00
Author: Kuo Jen Wei <inker@google.com>
Date: Mon Nov 19 15:09:15 2018

arc-setup: Chown generated camera profile to arc-camera

Align owner and group of camera profile generated from arc-setup with
the profile generated from chrome-setup to arc-camera.

BUG=chromium:905719
TEST=emerge arc-setup and "restart ui", verify owner, group of newly
install camera profile.

Change-Id: If13190c6d89da3c0b58fc17b955a2b8e3293bcf1
Reviewed-on: https://chromium-review.googlesource.com/1341608
Commit-Ready: Kuo Jen Wei <inker@chromium.org>
Tested-by: Kuo Jen Wei <inker@chromium.org>
Reviewed-by: Shik Chen <shik@chromium.org>

[modify] https://crrev.com/c6b7fb69842f05f444963006b56eed34dff4fe00/arc/setup/arc_setup.cc

Unless I'm misreading, this looks like it still doesn't match the code in session_manager. We use chronos:arc-camera 0770 there (see first link in original bug description). Isn't https://crrev.com/c/1341608 just setting a file within that directory to arc-camera:arc-camera? What happens if it creates the directory?
I found many generate_camera_profile shell script on overlays.
IIRC, it also creates the directory owned by root user...?

Sign in to add a comment