New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 905714 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

VariationsServiceStartsRequestOnNetworkChange test should use a VariationsService mock.

Project Member Reported by carlosil@chromium.org, Nov 15

Issue description

The ChromeBrowserMainBrowserTest.VariationsServiceStartsRequestOnNetworkChange test performs a real Variations request in order to check a request is performed upon network changes. To make the test more resilient to unrelated changes it should instead use a mock of the service that just registers when it attempts a fetch, similar to the TestVariationsService used in other tests (https://cs.chromium.org/chromium/src/components/variations/service/variations_service_unittest.cc?rcl=47f35a3192cb23183bb07f35aa5d50da31ab0e98&l=114)
 

Sign in to add a comment